Bug 320517 - [kde-windows] akonaditray lacks icon in the start menu
Summary: [kde-windows] akonaditray lacks icon in the start menu
Status: RESOLVED FIXED
Alias: None
Product: Akonadi
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks: 320424
  Show dependency treegraph
 
Reported: 2013-05-31 07:17 UTC by Jekyll Wu
Modified: 2013-05-31 14:57 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jekyll Wu 2013-05-31 07:17:06 UTC
See bug 320424

I notice that the build system actually already contains the call of kde4_add_app_icon :

kdepim-runtime/tray/CMakeLists.txt: kde4_add_app_icon(tray_sources "${KDE4_ICON_DIR}/oxygen/*/apps/akonadi.png")


My random guess: shouldn't  KDE4_ICON_DIR be replaced by KDE4_ICON_INSTALL_DIR ?
Comment 1 Laurent Montel 2013-05-31 07:39:57 UTC
For me yes
KDE4_ICON_DIR doesn't exist.

Regards
Comment 2 Patrick Spendrin 2013-05-31 07:55:10 UTC
It actually should be KDE4_INSTALL_DIR (which is an ugly hack, I know)
Comment 3 Christophe Marin 2013-05-31 10:50:47 UTC
the correct fix is to have a copy of these icons, rename them to avoid conflict and have them installed in the hicolor namespace
Comment 4 Christophe Marin 2013-05-31 10:51:30 UTC
I'll fix that this afternoon
Comment 5 Christophe Marin 2013-05-31 14:06:01 UTC
Git commit 16776709a5b690d4c0e4a90b43184ea728356d66 by Christophe Giboudeaux.
Committed on 31/05/2013 at 15:35.
Pushed by cgiboudeaux into branch 'KDE/4.10'.

Add icon for akonaditray

M  +3    -1    tray/CMakeLists.txt
M  +1    -1    tray/akonaditray.desktop
M  +1    -1    tray/dock.cpp
A  +1    -0    tray/icons/CMakeLists.txt
A  +-    --    tray/icons/hi128-app-akonaditray.png
A  +-    --    tray/icons/hi22-app-akonaditray.png
A  +-    --    tray/icons/hi32-app-akonaditray.png
A  +-    --    tray/icons/hi64-app-akonaditray.png
A  +-    --    tray/icons/hisc-app-akonaditray.svgz
M  +1    -1    tray/main.cpp

http://commits.kde.org/kdepim-runtime/16776709a5b690d4c0e4a90b43184ea728356d66
Comment 6 Patrick Spendrin 2013-05-31 14:57:31 UTC
Git commit 70c6caa01118c7ba9cc49ce997e38297d484f8fd by Patrick Spendrin.
Committed on 31/05/2013 at 16:56.
Pushed by sengels into branch 'kde-4.10'.

fix app icon the easy way

M  +2    -0    portage/kde/kdepim-runtime/kdepim-runtime-20101222.py
A  +12   -0    portage/kde/kdepim-runtime/kdepim-runtime-4.10.2-20130531.diff

http://commits.kde.org/emerge/70c6caa01118c7ba9cc49ce997e38297d484f8fd