most widgets still uses the old paint event style method draw. Instead it should use the paint() method for painting. Reproducible: Always Steps to Reproduce: 1. open umbrello/widgets/widgetbase.h 2. search for method draw( Actual Results: You will find several locations where this method has been used Expected Results: paint methods should use paint()
Git commit 4d2510a1d975b2d934dd61d9083b44911f10fafb by Ralf Habacker. Committed on 03/06/2013 at 23:25. Pushed by habacker into branch 'feature-320463-get-rid-of-old-paint-api'. Migrate CategoryWidget::draw() to qt4 paint api. M +9 -9 umbrello/widgets/categorywidget.cpp M +1 -1 umbrello/widgets/categorywidget.h http://commits.kde.org/umbrello/4d2510a1d975b2d934dd61d9083b44911f10fafb
Git commit f7933f48959fbb7032bb00ab2ad668dbf57c9593 by Ralf Habacker. Committed on 04/06/2013 at 21:15. Pushed by habacker into branch 'feature-320463-get-rid-of-old-paint-api'. Migrate ClassifierWidget::draw() to qt4 paint api. M +48 -46 umbrello/widgets/classifierwidget.cpp M +3 -3 umbrello/widgets/classifierwidget.h http://commits.kde.org/umbrello/f7933f48959fbb7032bb00ab2ad668dbf57c9593
Git commit 6e4c0cc25a3b588ba429941f831f49fbeaab3b28 by Ralf Habacker. Committed on 03/06/2013 at 23:24. Pushed by habacker into branch 'feature-320463-get-rid-of-old-paint-api'. Migrate BoxWidget::draw() to qt4 paint api. M +6 -4 umbrello/widgets/boxwidget.cpp M +1 -1 umbrello/widgets/boxwidget.h http://commits.kde.org/umbrello/6e4c0cc25a3b588ba429941f831f49fbeaab3b28
Git commit 3f257016e3c62d89d793486c19c98aad55cb09b9 by Ralf Habacker. Committed on 09/06/2013 at 22:32. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Migrate FloatingDashLineWidget::draw() to qt4 paint api. M +10 -7 umbrello/widgets/floatingdashlinewidget.cpp M +1 -1 umbrello/widgets/floatingdashlinewidget.h http://commits.kde.org/umbrello/3f257016e3c62d89d793486c19c98aad55cb09b9
Git commit 1e4fbf6eea37f21e3d875cf6cbad0311db0265a9 by Ralf Habacker. Committed on 09/06/2013 at 22:19. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Migrate CombinedFragmentWidget::draw() to qt4 paint api. M +27 -25 umbrello/widgets/combinedfragmentwidget.cpp M +1 -1 umbrello/widgets/combinedfragmentwidget.h http://commits.kde.org/umbrello/1e4fbf6eea37f21e3d875cf6cbad0311db0265a9
Git commit 0c950d3d4ed5be544f48f07871d80112de08dfb8 by Ralf Habacker. Committed on 09/06/2013 at 22:33. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Fixed FloatingDashLineWidget painting artifacts caused by not set widget height. M +4 -4 umbrello/widgets/combinedfragmentwidget.cpp M +3 -0 umbrello/widgets/floatingdashlinewidget.cpp http://commits.kde.org/umbrello/0c950d3d4ed5be544f48f07871d80112de08dfb8
Git commit 5e31da8de4c8c331328d2b7cfab84514828a81ba by Ralf Habacker. Committed on 11/06/2013 at 07:08. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Migrate ComponentWidget::draw() to qt4 paint api. M +19 -16 umbrello/widgets/componentwidget.cpp M +1 -1 umbrello/widgets/componentwidget.h http://commits.kde.org/umbrello/5e31da8de4c8c331328d2b7cfab84514828a81ba
Git commit a882488f9e3a062cf677ba665f6694a693d55047 by Ralf Habacker. Committed on 09/06/2013 at 22:37. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Crash fix caused by removing a FloatingDashLineWidget from the gui but not from CombinedFragmentWidget::m_dashLines. M +9 -3 umbrello/widgets/combinedfragmentwidget.cpp M +1 -0 umbrello/widgets/combinedfragmentwidget.h M +6 -2 umbrello/widgets/floatingdashlinewidget.cpp M +3 -1 umbrello/widgets/floatingdashlinewidget.h http://commits.kde.org/umbrello/a882488f9e3a062cf677ba665f6694a693d55047
Git commit 434aca119f2c821062f547b451dd30617ff4b5a1 by Ralf Habacker. Committed on 11/06/2013 at 10:24. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Migrate DataTypeWidget::draw() to qt4 paint api. M +14 -11 umbrello/widgets/datatypewidget.cpp M +1 -1 umbrello/widgets/datatypewidget.h http://commits.kde.org/umbrello/434aca119f2c821062f547b451dd30617ff4b5a1
Git commit fe2d56ccb3e67fcf46efbeb0a01679eee5780dea by Ralf Habacker. Committed on 09/06/2013 at 22:38. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Removed obsolate call to setY(), which has already been called in UMLWidget::loadFromXMI(). M +0 -1 umbrello/widgets/floatingdashlinewidget.cpp http://commits.kde.org/umbrello/fe2d56ccb3e67fcf46efbeb0a01679eee5780dea
Git commit 358ae95d18e3df88924e6b12f4eab3aefd311ada by Ralf Habacker. Committed on 09/06/2013 at 22:34. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Avoid double painting of FloatingDashLineWidget; it is painted by QGraphicsScene already. M +6 -2 umbrello/widgets/combinedfragmentwidget.cpp http://commits.kde.org/umbrello/358ae95d18e3df88924e6b12f4eab3aefd311ada
Git commit 87d9dc90765df4425a54a3db16a573b92b01ccfe by Ralf Habacker. Committed on 11/06/2013 at 10:47. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Migrate EntityWidget::draw() to qt4 paint api. M +24 -21 umbrello/widgets/entitywidget.cpp M +1 -2 umbrello/widgets/entitywidget.h http://commits.kde.org/umbrello/87d9dc90765df4425a54a3db16a573b92b01ccfe
Git commit 1897fd5afd4b5a4556ba93680b762763e33fa78e by Ralf Habacker. Committed on 11/06/2013 at 10:56. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Migrate FloatingTextWidget::draw() to qt4 paint api. M +8 -5 umbrello/widgets/floatingtextwidget.cpp M +1 -1 umbrello/widgets/floatingtextwidget.h http://commits.kde.org/umbrello/1897fd5afd4b5a4556ba93680b762763e33fa78e
Git commit e22121e599bad69cc0895d58f7b65cd0e5fb2771 by Ralf Habacker. Committed on 11/06/2013 at 11:14. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Migrate ForkJoinWidget::draw() to qt4 paint api. M +10 -4 umbrello/widgets/forkjoinwidget.cpp M +2 -2 umbrello/widgets/forkjoinwidget.h http://commits.kde.org/umbrello/e22121e599bad69cc0895d58f7b65cd0e5fb2771
Git commit cc7ef1c8eb6fb7a72d084ca91d115f1a36a90375 by Ralf Habacker. Committed on 11/06/2013 at 13:55. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Migrate Nodewidget::draw() to qt4 paint api. M +24 -21 umbrello/widgets/nodewidget.cpp M +1 -1 umbrello/widgets/nodewidget.h http://commits.kde.org/umbrello/cc7ef1c8eb6fb7a72d084ca91d115f1a36a90375
Git commit 0dcad970ba053f3b55b3d2267abd3527ac54a002 by Ralf Habacker. Committed on 11/06/2013 at 17:10. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Migrate NoteWidget::draw() to qt4 paint api. M +41 -37 umbrello/widgets/notewidget.cpp M +4 -4 umbrello/widgets/notewidget.h http://commits.kde.org/umbrello/0dcad970ba053f3b55b3d2267abd3527ac54a002
Git commit e60a2cb24d1b222de4e4b416c00678e7369ae44d by Ralf Habacker. Committed on 11/06/2013 at 17:21. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Migrate ObjectNodeWidget::draw() to qt4 paint api. M +21 -18 umbrello/widgets/objectnodewidget.cpp M +1 -1 umbrello/widgets/objectnodewidget.h http://commits.kde.org/umbrello/e60a2cb24d1b222de4e4b416c00678e7369ae44d
Git commit c4e59af333bcecb9d5db26ab0b23dd111aba6b2e by Ralf Habacker. Committed on 11/06/2013 at 17:23. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Removed obsolete call to setPenFromSettings() M +0 -1 umbrello/widgets/objectnodewidget.cpp http://commits.kde.org/umbrello/c4e59af333bcecb9d5db26ab0b23dd111aba6b2e
Git commit 174777ce178eda4df5571c6674ab5d9d592eab4e by Ralf Habacker. Committed on 11/06/2013 at 21:22. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Migrate RegionWidget::draw() to qt4 paint api. M +10 -7 umbrello/widgets/regionwidget.cpp M +1 -1 umbrello/widgets/regionwidget.h http://commits.kde.org/umbrello/174777ce178eda4df5571c6674ab5d9d592eab4e
Git commit 2d10ddde7ac9431f1927115be2248009397129ea by Ralf Habacker. Committed on 11/06/2013 at 20:13. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Migrate PackageWidget::draw() to qt4 paint api. M +20 -17 umbrello/widgets/packagewidget.cpp M +1 -1 umbrello/widgets/packagewidget.h http://commits.kde.org/umbrello/2d10ddde7ac9431f1927115be2248009397129ea
Git commit 271965627be7d7351a095cf7a768cf37a6da9ee1 by Ralf Habacker. Committed on 11/06/2013 at 21:38. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Migrate StateWidget::draw() to qt4 paint api. M +54 -50 umbrello/widgets/statewidget.cpp M +1 -1 umbrello/widgets/statewidget.h http://commits.kde.org/umbrello/271965627be7d7351a095cf7a768cf37a6da9ee1
Git commit eb751067d08b40d2389a0fa02c7c9c7d8680e24c by Ralf Habacker. Committed on 11/06/2013 at 21:46. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Migrate UseCaseWidget::draw() to qt4 paint api. M +12 -9 umbrello/widgets/usecasewidget.cpp M +1 -1 umbrello/widgets/usecasewidget.h http://commits.kde.org/umbrello/eb751067d08b40d2389a0fa02c7c9c7d8680e24c
Git commit 567bb7be6978f0b4b260c6fe026e84aec160909f by Ralf Habacker. Committed on 11/06/2013 at 22:08. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Migrate ObjectWidget::draw() to qt4 paint api. M +34 -31 umbrello/widgets/objectwidget.cpp M +4 -4 umbrello/widgets/objectwidget.h http://commits.kde.org/umbrello/567bb7be6978f0b4b260c6fe026e84aec160909f
Git commit 0207c4ddd51281756225bc6cfe12f068d98b2d47 by Ralf Habacker. Committed on 11/06/2013 at 22:30. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Use camel case variable name. M +13 -13 umbrello/widgets/pinwidget.cpp http://commits.kde.org/umbrello/0207c4ddd51281756225bc6cfe12f068d98b2d47
Git commit 47c9e3bc0d1944841c848fee92c392807b20f3b0 by Ralf Habacker. Committed on 11/06/2013 at 22:20. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Migrate SignalWidget::draw() to qt4 paint api. M +39 -37 umbrello/widgets/signalwidget.cpp M +1 -1 umbrello/widgets/signalwidget.h http://commits.kde.org/umbrello/47c9e3bc0d1944841c848fee92c392807b20f3b0
Git commit fda5f07b74fa9ba470e391afc3f33f785aebf99c by Ralf Habacker. Committed on 12/06/2013 at 00:56. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Migrate PinWidget::draw() to qt4 paint api. M +12 -9 umbrello/widgets/pinwidget.cpp M +1 -1 umbrello/widgets/pinwidget.h http://commits.kde.org/umbrello/fda5f07b74fa9ba470e391afc3f33f785aebf99c
Git commit 31ea463d07234b9e5c5264cce937f532cd0cfe8c by Ralf Habacker. Committed on 12/06/2013 at 09:32. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Removed debug painting. M +0 -1 umbrello/widgets/notewidget.cpp http://commits.kde.org/umbrello/31ea463d07234b9e5c5264cce937f532cd0cfe8c
Git commit d6e71e5612749fb00e6e3cc580c895e2cb5ea66a by Ralf Habacker. Committed on 12/06/2013 at 13:21. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Migrate ArtifactWidget::draw() to qt4 paint api. M +66 -63 umbrello/widgets/artifactwidget.cpp M +5 -5 umbrello/widgets/artifactwidget.h http://commits.kde.org/umbrello/d6e71e5612749fb00e6e3cc580c895e2cb5ea66a
Git commit 3b7fadaebef968283bc16471835342506f849312 by Ralf Habacker. Committed on 12/06/2013 at 13:43. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Migrate PreconditionWidget::draw() to qt4 paint api. M +12 -9 umbrello/widgets/preconditionwidget.cpp M +2 -2 umbrello/widgets/preconditionwidget.h http://commits.kde.org/umbrello/3b7fadaebef968283bc16471835342506f849312
Git commit 1815ce4dc8523e37d12bd4d4cea164f622513703 by Ralf Habacker. Committed on 12/06/2013 at 13:44. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Doc fix. M +1 -1 umbrello/widgets/objectwidget.cpp http://commits.kde.org/umbrello/1815ce4dc8523e37d12bd4d4cea164f622513703
Git commit c977723344bdc8f0a155fe6918f8c5e958ff4f6a by Ralf Habacker. Committed on 12/06/2013 at 14:11. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Removed obsolete offset.. parameters from paint related MessageWidget methods. Also changed parameter type from QPainter& to QPainter *. M +74 -67 umbrello/widgets/messagewidget.cpp M +7 -7 umbrello/widgets/messagewidget.h http://commits.kde.org/umbrello/c977723344bdc8f0a155fe6918f8c5e958ff4f6a
Git commit cb5df7d55de0822e54381b04aa5d9de293bc6b51 by Ralf Habacker. Committed on 12/06/2013 at 13:52. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Removed obsolete methods. M +1 -1 umbrello/dotgenerator.cpp M +0 -10 umbrello/widgets/umlwidget.cpp M +0 -1 umbrello/widgets/umlwidget.h M +0 -6 umbrello/widgets/widgetbase.cpp M +0 -1 umbrello/widgets/widgetbase.h http://commits.kde.org/umbrello/cb5df7d55de0822e54381b04aa5d9de293bc6b51
Git commit 4839298b15ebc1613509e8cf25d764eaf69dddef by Ralf Habacker. Committed on 12/06/2013 at 13:54. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. compiler warning-- M +3 -0 umbrello/widgets/categorywidget.cpp http://commits.kde.org/umbrello/4839298b15ebc1613509e8cf25d764eaf69dddef
Git commit a1d6225a4477c3b684d81eac4476be42e82dd461 by Ralf Habacker. Committed on 12/06/2013 at 13:55. Pushed by habacker into branch '320463-get-rid-of-old-paint-api'. Renamed drawSelected() to paintSelected() M +1 -1 umbrello/widgets/activitywidget.cpp M +1 -1 umbrello/widgets/actorwidget.cpp M +4 -4 umbrello/widgets/artifactwidget.cpp M +1 -1 umbrello/widgets/boxwidget.cpp M +1 -1 umbrello/widgets/categorywidget.cpp M +2 -2 umbrello/widgets/classifierwidget.cpp M +1 -1 umbrello/widgets/combinedfragmentwidget.cpp M +1 -1 umbrello/widgets/componentwidget.cpp M +1 -1 umbrello/widgets/datatypewidget.cpp M +1 -1 umbrello/widgets/entitywidget.cpp M +1 -1 umbrello/widgets/enumwidget.cpp M +1 -1 umbrello/widgets/floatingdashlinewidget.cpp M +1 -1 umbrello/widgets/floatingtextwidget.cpp M +2 -2 umbrello/widgets/forkjoinwidget.cpp M +1 -1 umbrello/widgets/forkjoinwidget.h M +5 -5 umbrello/widgets/messagewidget.cpp M +1 -1 umbrello/widgets/nodewidget.cpp M +1 -1 umbrello/widgets/notewidget.cpp M +1 -1 umbrello/widgets/objectnodewidget.cpp M +1 -1 umbrello/widgets/objectwidget.cpp M +1 -1 umbrello/widgets/packagewidget.cpp M +1 -1 umbrello/widgets/pinwidget.cpp M +1 -1 umbrello/widgets/preconditionwidget.cpp M +1 -1 umbrello/widgets/regionwidget.cpp M +1 -1 umbrello/widgets/signalwidget.cpp M +1 -1 umbrello/widgets/statewidget.cpp M +1 -1 umbrello/widgets/umlwidget.cpp M +1 -1 umbrello/widgets/umlwidget.h M +1 -1 umbrello/widgets/usecasewidget.cpp http://commits.kde.org/umbrello/a1d6225a4477c3b684d81eac4476be42e82dd461