Bug 320304 - Aspect ratio not rounded and displays useless fractions
Summary: Aspect ratio not rounded and displays useless fractions
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Editor-Crop (show other bugs)
Version: 3.3.0
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-26 12:11 UTC by Michael G. Hansen
Modified: 2017-08-08 09:01 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.4.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael G. Hansen 2013-05-26 12:11:25 UTC
For images which do not have exactly an aspect ratio of for example 3:2, the aspect ratio is for example displayed as 1953:1301 (1.50). However, 1953:1301 is not really useful for human interpretation ;-) I suggest to use rounding for the conversion to fractions, and instead display more digits for the non-fractional display, allowing the user to easily see how closely the image resembles the aspect ratio: 3:2 (1.5012).

Reproducible: Always
Comment 1 caulier.gilles 2013-11-25 14:32:32 UTC
Pankaj,

I remember that you have work on Aspect Ratio info features in the past.

Any help are welcome here...

Thanks in advance

Gilles Caulier
Comment 2 caulier.gilles 2014-09-11 09:14:32 UTC
Git commit 477c457262854d83374961cbdb6d38d5aa1adf42 by Gilles Caulier.
Committed on 11/09/2014 at 09:13.
Pushed by cgilles into branch 'master'.

Factorize : use same code in tooltip and icon-view to show image Aspect Ratio information.

M  +0    -1    app/settings/applicationsettings.h
M  +1    -43   app/utils/tooltipfiller.cpp
M  +0    -1    app/utils/tooltipfiller.h
M  +5    -3    app/views/tableview/tableview_column_item.cpp
M  +42   -0    libs/imageproperties/imagepropertiestab.cpp
M  +8    -0    libs/imageproperties/imagepropertiestab.h
M  +11   -41   libs/widgets/itemview/itemviewimagedelegate.cpp

http://commits.kde.org/digikam/477c457262854d83374961cbdb6d38d5aa1adf42
Comment 3 caulier.gilles 2014-09-11 13:02:40 UTC
Git commit 6a185199cbc523fc82908f8fa05579b2b1c1214d by Gilles Caulier.
Committed on 11/09/2014 at 13:01.
Pushed by cgilles into branch 'master'.

Round image aspect ratio fraction to be more human readbale
Addd aspect ration info in image properties panel
FIXED-IN: 4.4.0

M  +2    -1    NEWS
M  +1    -1    app/utils/tooltipfiller.cpp
M  +54   -51   app/views/tableview/tableview_column_item.cpp
M  +5    -0    libs/imageproperties/imagepropertiessidebar.cpp
M  +11   -0    libs/imageproperties/imagepropertiessidebardb.cpp
M  +109  -30   libs/imageproperties/imagepropertiestab.cpp
M  +4    -3    libs/imageproperties/imagepropertiestab.h
M  +1    -1    libs/widgets/itemview/itemviewimagedelegate.cpp

http://commits.kde.org/digikam/6a185199cbc523fc82908f8fa05579b2b1c1214d
Comment 4 caulier.gilles 2014-09-11 13:25:42 UTC
Git commit e9f2f599ce5853a3ae686c2d3346228fc7c03053 by Gilles Caulier.
Committed on 11/09/2014 at 13:25.
Pushed by cgilles into branch 'master'.

missing to add aspect ratio info in camera image properties tab

M  +44   -30   libs/imageproperties/cameraitempropertiestab.cpp
M  +3    -3    libs/imageproperties/imagepropertiessidebardb.cpp
M  +1    -0    libs/imageproperties/imagepropertiestab.cpp

http://commits.kde.org/digikam/e9f2f599ce5853a3ae686c2d3346228fc7c03053