Bug 319813 - Resizing synchronous message moves its position
Summary: Resizing synchronous message moves its position
Status: RESOLVED FIXED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: 2.10.2
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Umbrello Development Group
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-14 05:33 UTC by Christian Weiske
Modified: 2013-05-30 08:16 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.10.4


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Weiske 2013-05-14 05:33:35 UTC
When trying to resize a synchronous message in a sequence diagram, it gets moved up.

This makes it impossible to accurately set the size I need because it's not in the correct place anymore to make that decision.

Reproducible: Always

Steps to Reproduce:
1. Create sequence diagram
2. Add two objects
3. Add an asynchronous message between them
4. Add an synchronous message between them, with some space below the asynchronous one
5. Select the synchronous message 
6. Resize the synchronous message by dragging the bottom right

Actual Results:  
Synchronous message is moved up, directly below the asynchronous one.

Expected Results:  
The synchronous message does not move its position.
Comment 1 Ralf Habacker 2013-05-21 15:57:32 UTC
Git commit 897f521c65ae32c333e44556b3c67f6237a5b554 by Ralf Habacker.
Committed on 20/05/2013 at 12:08.
Pushed by habacker into branch 'master'.

Fixed bug variant of: Resizing synchronous message moves its position.

This commit fixes a variant of the related bug when loading message
widgets from a file. The shadow copy of widgets y position (m_nY)
has not been set.

The question is if this shadow copy of widget position is really required
or if it could be replaced by QGraphicsObject provided widget position.

M  +1    -0    umbrello/widgets/messagewidget.cpp

http://commits.kde.org/umbrello/897f521c65ae32c333e44556b3c67f6237a5b554
Comment 2 Oliver Kellogg 2013-05-21 19:36:01 UTC
(In reply to comment #1)
> [...]
> This commit fixes a variant of the related bug when loading message
> widgets from a file. The shadow copy of widgets y position (m_nY)
> has not been set.
> 
> The question is if this shadow copy of widget position is really required
> or if it could be replaced by QGraphicsObject provided widget position.
> 
Many moons ago I had concluded that m_nY is required but I can't remember exactly why this is so. Furthermore, perhaps the conclusion is outdated.
If you want to try to remove m_nY then please make sure to test the following:
1. Draw creation message
   (This is done by selecting async message and releasing it onto the target object widget to receive the creation message.)
2. Draw different message types form right to left
  (This is the inverse of the usual left-to-right message flow, and has been prone to regressions upon code changes in the past)

Thanks.
Comment 3 Ralf Habacker 2013-05-28 17:07:21 UTC
(In reply to comment #0)
> 
> Actual Results:  
> Synchronous message is moved up, directly below the asynchronous one.
> 
Some analysis: the vertical position of the message widget is *not* changed when the targeted object widgets has been moved horizontal after message widget up/down  move.
Comment 4 Ralf Habacker 2013-05-28 18:20:50 UTC
Git commit 6327e502db759a04ec97124b8639d3fb12fd4350 by Ralf Habacker.
Committed on 28/05/2013 at 20:19.
Pushed by habacker into branch 'master'.

Fixed bug: Resizing synchronous message moves its position.
FIXED-IN:4.10.4

M  +2    -1    umbrello/controller/umlwidgetcontroller.cpp
M  +1    -0    umbrello/widgets/messagewidget.cpp

http://commits.kde.org/umbrello/6327e502db759a04ec97124b8639d3fb12fd4350
Comment 5 Ralf Habacker 2013-05-30 08:14:18 UTC
Git commit 237361be6d5aed0477e77e9e057134f94340648b by Ralf Habacker.
Committed on 20/05/2013 at 12:08.
Pushed by habacker into branch 'KDE/4.10'.

Fixed bug variant of: Resizing synchronous message moves its position.

This commit fixes a variant of the related bug when loading message
widgets from a file. The shadow copy of widgets y position (m_nY)
has not been set.

The question is if this shadow copy of widget position is really required
or if it could be replaced by QGraphicsObject provided widget position.

M  +1    -0    umbrello/widgets/messagewidget.cpp

http://commits.kde.org/umbrello/237361be6d5aed0477e77e9e057134f94340648b
Comment 6 Ralf Habacker 2013-05-30 08:16:07 UTC
Git commit 3b4fa4abb7482d46b744e32a178373c44a4d452c by Ralf Habacker.
Committed on 28/05/2013 at 20:19.
Pushed by habacker into branch 'KDE/4.10'.

Fixed bug: Resizing synchronous message moves its position.
FIXED-IN:4.10.4

M  +2    -1    umbrello/controller/umlwidgetcontroller.cpp
M  +1    -0    umbrello/widgets/messagewidget.cpp

http://commits.kde.org/umbrello/3b4fa4abb7482d46b744e32a178373c44a4d452c