Bug 319705 - Undo/Redo should be available for moving images from/to trash too
Summary: Undo/Redo should be available for moving images from/to trash too
Status: CONFIRMED
Alias: None
Product: gwenview
Classification: Applications
Component: general (show other bugs)
Version: 4.10.3
Platform: Other Unspecified
: HI normal
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords: usability
: 351134 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-05-12 06:51 UTC by tesfabpel
Modified: 2024-03-20 15:49 UTC (History)
10 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tesfabpel 2013-05-12 06:51:36 UTC
When you press the Delete key on your keyboard in Gwenview it deletes the file without asking you the confirm or showing a popup in which it says "Deleted. Click here to undo" (like a Toast Notification :P).
It should also close the image on the program and display the next one or nothing...

Reproducible: Always

Steps to Reproduce:
1. Open a photo on Gwenview.
2. Press the "Delete" key.
Actual Results:  
The photo gets deleted without any feedback or confirmation dialog.
The deleted photo remains open in Gwenview.

Expected Results:  
A feedback with the option to undo or a confirmation dialog should appear.
Gwenview should show the next photo or nothing after the deletion.
Comment 1 Benni Hill 2013-06-04 20:46:12 UTC
Seems like gwenview respects a setting in dolphin. It's in the dolphin preferences under General -> Confirmations named "(Ask for confirmation when) Moving files or folder to trash". Can you please check if this was deactivated in your dolphin config and if gwenview asks for confirmation when you activate it?
Comment 2 tesfabpel 2013-06-05 08:36:31 UTC
Yes, that is the cause...
Anyway I've found that if you delete the last photo in the folder, gwenview will keep showing it instead saying something like "There are no photos in this folder..."
(In reply to comment #1)
> Seems like gwenview respects a setting in dolphin. It's in the dolphin
> preferences under General -> Confirmations named "(Ask for confirmation
> when) Moving files or folder to trash". Can you please check if this was
> deactivated in your dolphin config and if gwenview asks for confirmation
> when you activate it?
Comment 3 Nate Graham 2017-09-09 20:57:30 UTC
That would be nice. Maybe the image can go poof or something.
Comment 4 null 2017-12-10 20:09:19 UTC
There are multiple issues here:

1. Confirmation dialog when moving images to the trash:
As noted, this follows the (desktop wide) setting from Dolphin. This could be moved to systemsettings for easier discovery (with a link from Dolphin and Gwenview), but nothing for Gwenview to do here at the moment, really (adding a link to Dolphin would be weird).

2. Close image view or move to next image after deletion:
This has been fixed in b55420b2ac3d (Try to keep ContextManager in sync with viewed files in MainWindow)

3. Not being able to undo after moving images to the trash:
This works in Dolphin, but not in Gwenview. Essentially, this needs to be plugged into the existing undo/redo infrastructure by taking inspiration from Dolphin's code. Let's make the bug about this.

4. Toast notification instead of menu entry for undo
Yeah, a nice feature from mobile UIs. However, should be done in a coordinated effort across all apps by adding this to Frameworks, not only in Gwenview. Note we cannot just use Gwenview's undo bar, because this one is more about saving unsaved modifications and requires being able to jump back to the image in question. For now, adding it to the menu / as a shortcut should be good enough.
Comment 5 Mihai Sorin Dobrescu 2019-01-09 15:29:58 UTC
I came here by looking for a bug that is similar to this one, so I add it here.

1. Gwenview does not always go to the next image when the currently viewed one is moved to another path (with Gwenview). Sometimes goes, sometimes not. When it does not, moving to the next or previous image in Gwenview goes through the existing image, like it is there (possibly some handle remains busy?). Also, in that case, going to the browse view displays the previous image to the moved one twice, in place of the moved one too.

2.Undo must be available in Gwenview when Gwenview is used to move files wherever, to some other path or to trash, which is the same to me as other path. If I move a file from tens of thousands of images with it, and I need to undo that it's unhandy as I need to find it in a lot of files. Anyway, it is an operation, so undo must be available.
Comment 6 Simone Gaiarin 2019-02-24 08:46:53 UTC
*** Bug 351134 has been marked as a duplicate of this bug. ***
Comment 7 nahoj 2023-08-06 11:37:21 UTC
I support this, especially undo move to trash. I often delete images from Gwenview, but I find it pretty tedious when I delete one by mistake and I have to go to and through the trash to restore it. It would be great to be able to just Ctrl+Z.