Bug 319663 - ark does not display any message if unrar is not install
Summary: ark does not display any message if unrar is not install
Status: RESOLVED FIXED
Alias: None
Product: ark
Classification: Applications
Component: general (show other bugs)
Version: 2.19
Platform: Mageia RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Raphael Kubo da Costa
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2013-05-11 13:15 UTC by Olivier Delaune
Modified: 2013-06-30 17:06 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.11.0
Sentry Crash Report:


Attachments
One-line solution to the bug. (296 bytes, text/plain)
2013-06-29 18:35 UTC, Sajtos
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Delaune 2013-05-11 13:15:11 UTC
Hello, I try to open a rar archive with ark while I did not install unrar. I double clicked on rar file, ark opened. There was no file in the ark box. I waited a long time because ark looks like to work ("hourglass" cursor) and finally I understood: unrar was not install on my computer.
Could you add a message to warn the user that ark cannot open rar file because unrar is not installed for example?

Reproducible: Always
Comment 1 Sajtos 2013-06-29 13:53:48 UTC
Hello.

This comment can be considered as an related bug report.
I tried to produce an .rar archive, but the same symptom appeared.

The cause was the same: rar was not installed on my computer.
So we can extend this bug report.

I am going to test it with unzip/zip, maybe the problem is greater than I thought.
Comment 2 Sajtos 2013-06-29 18:35:43 UTC
Created attachment 80856 [details]
One-line solution to the bug.

The patch is really simple, so if I couldn't make a correct patch, please give me some advice.

The patch worked on my computer, but ofc confirmation needed.
Comment 3 Raphael Kubo da Costa 2013-06-29 19:08:24 UTC
Can you please send it via ReviewBoard (git.reviewboard.kde.org)? BTW, please use Qt's coding style as in the rest of the file.
Comment 4 Sajtos 2013-06-29 19:58:15 UTC
(In reply to comment #3)
> Can you please send it via ReviewBoard (git.reviewboard.kde.org)? BTW,
> please use Qt's coding style as in the rest of the file.

Okay, now I used the required coding style.

https://git.reviewboard.kde.org/r/111318/

Is it visible, or only I can view it?
Comment 5 Raphael Kubo da Costa 2013-06-29 20:03:00 UTC
It isn't. Please make sure you add the "kdeutils" group to the request and then click the "Publish" button.

I'll take a look at it as soon as I can.
Comment 6 Sajtos 2013-06-29 20:05:27 UTC
(In reply to comment #5)
> It isn't. Please make sure you add the "kdeutils" group to the request and
> then click the "Publish" button.
> 
> I'll take a look at it as soon as I can.

Okay, in the meantime I found the correct group. These administrative things are a bit complicated at the first time, aren't they? :D

So the review is successfully published.
Comment 7 Raphael Kubo da Costa 2013-06-30 17:06:15 UTC
Git commit a3736e60172d604144b5eee7c62600066f6e2d6c by Raphael Kubo da Costa.
Committed on 30/06/2013 at 16:59.
Pushed by rkcosta into branch 'master'.

Emit finished() when runProcess does not find any program.

This fixes a regression introduced in c7af2d6: while the `finished' signal
will be emitted correctly in most cases, if none of the executables passed
to CliInterface::runProcess() are found only the `error' signal would be
sent, and the program would wait for a `finished' signal forever and never
notify the user that the required programs were not found.

Submitted by:	Ádám István Mózes <sajtos@sch.bme.hu>
REVIEW:		111318
FIXED-IN:	4.11.0

M  +1    -0    kerfuffle/cliinterface.cpp

http://commits.kde.org/ark/a3736e60172d604144b5eee7c62600066f6e2d6c