Bug 319554 - Select all wont works if the select text tool is enabled
Summary: Select all wont works if the select text tool is enabled
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 0.16.2
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-09 00:11 UTC by Cochise César
Modified: 2013-05-20 16:17 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/okular/4e05cc2526aaa86ae9c0fb3cd276945b88164cda
Version Fixed In: 4.10.4
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Cochise César 2013-05-09 00:11:22 UTC 
For me, in ODT and PDF files, the Select All action isn't performed if I'm using the Select Text tool. With navigate, zoom, select tables or the traditional select.

Reproducible: Always

Steps to Reproduce:
1. open a file with text
2. active select text tool
3. try to select all, via menu or shortcut
Actual Results:  
nothing

Expected Results:  
all text to be selected
Comment 1 Albert Astals Cid 2013-05-09 22:53:38 UTC 
Awesome, we went from Select All only working on Select mode to Select All not working on Select mode :-/

Should be trivial to fix but a bit busy until next week, if someone beats me for a patch i'll be happy ;-)
Comment 2 Albert Astals Cid 2013-05-20 16:17:13 UTC 
Git commit 4e05cc2526aaa86ae9c0fb3cd276945b88164cda by Albert Astals Cid.
Committed on 20/05/2013 at 18:15.
Pushed by aacid into branch 'KDE/4.10'.

Fix wrong check

Parker messed up the logic that force it to be in text selection mode
to be on non text selecion mode when doing an unrelated change.

As the "bug" as showed we can selectAll in non text selection mode as well
so remove the check altogether
Related: bug 159276
FIXED-IN: 4.10.4

M  +0    -3    ui/pageview.cpp

http://commits.kde.org/okular/4e05cc2526aaa86ae9c0fb3cd276945b88164cda