Bug 319455 - Kopete with enabled video support fails to build on recent kernels
Summary: Kopete with enabled video support fails to build on recent kernels
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Applications
Component: libkopete (show other bugs)
Version: 1.4.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-07 09:26 UTC by eseifert
Modified: 2013-05-16 23:41 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.10.4


Attachments
Patch to make deprecated V4L2 controls in Kopete optional (760 bytes, patch)
2013-05-07 09:29 UTC, eseifert
Details

Note You need to log in before you can comment on or make changes to this bug.
Description eseifert 2013-05-07 09:26:09 UTC
Building Kopete on my Gentoo system with enabled video support on kernel 3.9 fails with an error. The error logs show that this is caused by undeclared V4L2 constants (V4L2_CID_HCENTER and V4L2_CID_VCENTER). It seems these constants have been removed in kernel 3.7.

Reproducible: Always

Steps to Reproduce:
1. Build kopete with -DDISABLE_VIDEOSUPPORT=OFF on kernel 3.7 or higher
Actual Results:  
Make fails with an error:
/var/tmp/portage/kde-base/kopete-4.10.3/work/kopete-4.10.3/kopete/libkopete/avdevice/videodevice.cpp: In member function 'const char* Kopete::AV::VideoDevice::getUnifiedV4L2StdCtrlName(quint32)':
/var/tmp/portage/kde-base/kopete-4.10.3/work/kopete-4.10.3/kopete/libkopete/avdevice/videodevice.cpp:3064:8: error: 'V4L2_CID_HCENTER' was not declared in this scope
/var/tmp/portage/kde-base/kopete-4.10.3/work/kopete-4.10.3/kopete/libkopete/avdevice/videodevice.cpp:3065:8: error: 'V4L2_CID_VCENTER' was not declared in this scope


Expected Results:  
Should build without erros.
Comment 1 eseifert 2013-05-07 09:29:45 UTC
Created attachment 79750 [details]
Patch to make deprecated V4L2 controls in Kopete optional

Here's a patch that checks for the constants using an #ifdef before using them.
Comment 2 Michael Palimaka 2013-05-10 17:02:20 UTC
SVN commit 1353735 by palimaka:

Fix build with V4L and recent kernels.

REVIEW: 7072


 M  +4 -0      videodevice.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1353735
Comment 3 Michael Palimaka 2013-05-10 17:03:56 UTC
SVN commit 1353736 by palimaka:

Fix build with V4L and recent kernels.

REVIEW: 7072


 M  +4 -0      videodevice.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1353736