After modifying an annotation's properties (i.e. right click -> properties) in a rotated document, its ObjectRect (=the object used for mouse hit testing) gets wrong.
Its normalized coordinates would be correct if the document was not rotated, so it must be a missing rotation somewhere.
This happens on any document, I'm attaching an example one I've made to better explain the issue.
Steps to Reproduce:
1. Open the attached document
2. Rotate it by 90 degrees so that the text looks horizontal
3. Right-click on the annotation and edit some property (e.g. its color)
5. Notice how right-click no longer works properly: the hitbox now roughly corresponds to the blue area. Right clicks on the upper/lower parts of the ellipse don't "find" the annotation.
Created attachment 79428 [details]
Example PDF file
Created attachment 79429 [details]
I've tried to fix it myself, and the attached patch indeed fixes the issue, but it's obviously a wrong fix.
Jon, can you have a look at this issue?
Sure thing. May be a few days but I'll take a look soon.
Proposed fix and unit test submitted for review https://git.reviewboard.kde.org/r/110229/
Git commit 4296ac7e5dd579aa43845df80739c6a4f45284db by Albert Astals Cid, on behalf of Jon Mease.
Committed on 07/05/2013 at 22:05.
Pushed by aacid into branch 'master'.
Rotate annotation to match page when setting annotation's properties
M +3 -0 core/annotations.cpp
M +30 -0 tests/modifyannotationpropertiestest.cpp