Bug 318529 - Add contact dialog should allow to set a message for the user
Summary: Add contact dialog should allow to set a message for the user
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Unmaintained
Component: common-internals (show other bugs)
Version: git-latest
Platform: Other Linux
: NOR wishlist
Target Milestone: Future
Assignee: Telepathy Bugs
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2013-04-17 23:07 UTC by Daniele E. Domenichelli
Modified: 2014-03-30 15:50 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/telepathy-common-internals/ada8ab0b03d1fdb649f961df5fe6646080aa2c14
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Daniele E. Domenichelli 2013-04-17 23:07:08 UTC 
Most protocols allow to set a message for the user when you add them, we should support this
Comment 1 David Edmundson 2013-04-17 23:11:45 UTC 
See
Tp::Contact::publishStateMessage () for this message.

You may also need to add the relevant other code when adding contacts for testing.
Comment 2 David Edmundson 2014-03-30 15:50:52 UTC 
Git commit ada8ab0b03d1fdb649f961df5fe6646080aa2c14 by David Edmundson, on behalf of Daniel Cohen.
Committed on 30/03/2014 at 15:51.
Pushed by davidedmundson into branch 'master'.

Added presence request message in the add contact dialog

Added an optional text input line for the capability of sending a message with presence requests.

I'm not entirely sure of the HIG for making it clear that it's an optional field, so put the label below for now - putting 'message (optional)' on the left-hand label looks unreasonably awkward to me.

REVIEW: 117138

M  +16   -1    KTp/Widgets/add-contact-dialog.cpp
M  +1    -0    KTp/Widgets/add-contact-dialog.h
M  +24   -7    KTp/Widgets/add-contact-dialog.ui

http://commits.kde.org/telepathy-common-internals/ada8ab0b03d1fdb649f961df5fe6646080aa2c14