Bug 318434 - Levels and Curves filters work buggy with layers which have different color space.
Summary: Levels and Curves filters work buggy with layers which have different color s...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Filters (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords: release_blocker
Depends on:
Blocks:
 
Reported: 2013-04-16 09:03 UTC by Paul Geraskin
Modified: 2013-04-19 14:52 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Just open Levels and switch preview on. (1.39 MB, application/x-krita)
2013-04-16 09:03 UTC, Paul Geraskin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Geraskin 2013-04-16 09:03:31 UTC
Created attachment 78954 [details]
Just open Levels and switch preview on.

Levels and Curves filters work buggy with layers which have different color space.
Just open Levels and switch preview on.
I added kra file.
Comment 1 Halla Rempt 2013-04-16 10:11:27 UTC
I think this is a regression that broke after 5ddfad2ae05d2ec14b6fcbe164ff23d8584b32df

I still need to test, but I think it's a regression, so a release_blocker for 2.7.
Comment 2 Halla Rempt 2013-04-16 13:44:53 UTC
Okay, I can confirm that the bug got introduced when the cs conversion performance fixes were committed.
Comment 3 Dmitry Kazakov 2013-04-19 06:50:05 UTC
Well, I just checked and this bug is present in 5ddfad2ae05d2ec14b6fcbe164ff23d8584b32df~1. Anyway, I'll look at it.
Comment 4 Dmitry Kazakov 2013-04-19 14:52:56 UTC
Git commit 28602d287c7a25ec7c1f8b5c4c6391de21ecf0ab by Dmitry Kazakov.
Committed on 19/04/2013 at 16:52.
Pushed by dkazakov into branch 'krita-testing-kazakov'.

Made the use of RenderingIntent and ConversionFlags consistens

Now for all internal conversions one must use:

KoColorConversionTransformation::InternalRenderingIntent
or
KoColorConversionTransformation::InternalConversionFlags

Or their Adjustment counterparts.

M  +2    -2    krita/image/kis_cross_device_color_picker.h
M  +3    -1    krita/image/kis_fixed_paint_device.cpp
M  +6    -6    krita/image/kis_fixed_paint_device.h
M  +3    -1    krita/image/kis_group_layer.cc
M  +6    -2    krita/image/kis_image.cc
M  +3    -1    krita/image/kis_layer.cc
M  +3    -1    krita/image/kis_mask.cc
M  +3    -1    krita/image/kis_paint_device.cc
M  +10   -10   krita/image/kis_paint_device.h
M  +4    -4    krita/image/kis_painter.cc
M  +3    -1    krita/image/kis_selection_based_layer.cpp
M  +3    -1    krita/image/tests/kis_colorspace_convert_visitor_test.cpp
M  +2    -2    krita/image/tests/kis_image_test.cpp
M  +10   -6    krita/image/tests/kis_selection_test.cpp
M  +1    -1    krita/plugins/extensions/dockers/advancedcolorselector/kis_common_colors.cpp
M  +3    -1    krita/plugins/extensions/dockers/historydocker/KisUndoModel.cpp
M  +1    -1    krita/plugins/filters/fastcolortransfer/fastcolortransfer.cpp
M  +1    -1    krita/plugins/filters/fastcolortransfer/kis_wdg_fastcolortransfer.cpp
M  +1    -1    krita/plugins/filters/phongbumpmap/kis_phong_bumpmap_filter.cpp
M  +1    -1    krita/plugins/formats/bmp/kis_bmp_export.cpp
M  +2    -2    krita/plugins/formats/jpeg/kis_jpeg_converter.cc
M  +2    -2    krita/plugins/formats/ppm/kis_ppm_export.cpp
M  +1    -1    krita/plugins/formats/tiff/kis_tiff_converter.cc
M  +1    -1    krita/plugins/paintops/libbrush/kis_brush.cpp
M  +1    -1    krita/plugins/paintops/libbrush/kis_gbr_brush.cpp
M  +4    -4    krita/plugins/paintops/mypaint/hint.txt
M  +3    -3    krita/plugins/paintops/mypaint/mypaint_surface.cpp
M  +5    -2    krita/plugins/tools/tool_transform2/kis_tool_transform.cc
M  +1    -1    krita/ui/kis_bookmarked_filter_configurations_model.cc
M  +1    -1    krita/ui/kis_clipboard.cc
M  +3    -1    krita/ui/kis_custom_pattern.cc
M  +3    -1    krita/ui/kis_filters_model.cc
M  +3    -1    krita/ui/kis_mimedata.cpp
M  +1    -1    krita/ui/kis_png_converter.cpp
M  +12   -4    krita/ui/tests/kis_prescaled_projection_test.cpp
M  +3    -3    krita/ui/widgets/kis_scratch_pad.cpp
M  +3    -3    libs/pigment/KoColor.cpp
M  +2    -2    libs/pigment/KoColorConversionSystem.cpp
M  +7    -0    libs/pigment/KoColorConversionTransformation.cpp
M  +5    -0    libs/pigment/KoColorConversionTransformation.h
M  +4    -4    libs/pigment/KoColorSpace.cpp
M  +1    -1    libs/pigment/KoCopyColorConversionTransformation.cpp
M  +2    -2    libs/pigment/KoFallBackColorTransformation.cpp
M  +1    -1    libs/pigment/KoScaleColorConversionTransformation.h
M  +12   -4    libs/pigment/colorspaces/KoSimpleColorSpace.h
M  +3    -1    libs/pigment/colorspaces/KoSimpleColorSpaceEngine.cpp
M  +18   -10   plugins/colorengines/lcms2/LcmsColorSpace.h
M  +7    -7    plugins/colorengines/lcms2/tests/TestKoCompositeOps.cpp

http://commits.kde.org/calligra/28602d287c7a25ec7c1f8b5c4c6391de21ecf0ab