In master branch, a new way to toggle the "Shift" button has been added by simplying pressing the Shift key. Due to use of toggle() instead of explicit up/down handling, its status is not tracked correctly. To reproduce (text in quotations marks are buttons, not keys): - start kcalc - click "6" button - hold down Shift key and keep it pressed - click "e^x" button - release Shift key Actual result: - the "Shift" button is still active Expected result: - releasing the Shift key should also release the "Shift" button
Additionally, as can be read on bug 283521, users might need to use the Shift key to enter numbers, so I do not think it is a wise choice to use that key for other purposes.
I am compelled to agree. That's why I didn't backport the Shift stuff to 4.10, cause I wasn't sure if it was a wise decision. After seeing your conclusions, I will probably remove this feature. I'll close this bug once that is done.
The patch has been rolled back, the negative side effects unfortunately outweigh the gain of being able to press Shift. I can't say that I love "Ctrl+2" being the shortcut currently, perhaps we can figure out some better shortcut in the future. But for now, it is as it was before this patch.