Bug 318347 - Resize for grid brush should affect the brush area, not particle size
Summary: Resize for grid brush should affect the brush area, not particle size
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Reinold Rojas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-14 15:27 UTC by valerievk
Modified: 2021-04-05 08:12 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description valerievk 2013-04-14 15:27:47 UTC
Currently, Shift+Drag for the grid brush changes the grid width and height (basically changing the particle size and changing the alignment). I suggest it should change the Scale value instead, which increases the area affected without changing the particle size.

The reason for this is to preserve grid alignment, which I think is the main reason users would want to use the grid brush. This would also be consistent with the behavior of the hatching brush, which also doesn't mess with the alignment, but just affects the area the brush covers.

Reproducible: Always
Comment 1 Halla Rempt 2013-06-21 11:08:48 UTC
It would make a lot of sense indeed.
Comment 2 Halla Rempt 2016-01-24 19:10:14 UTC
WISHGROUP: Larger Usability Fixes
Comment 3 Dmitry Kazakov 2021-04-05 08:12:28 UTC
Git commit 8aee6371a57b580034b016ce983f36b33e730835 by Dmitry Kazakov, on behalf of Reinold Rojas.
Committed on 05/04/2021 at 08:12.
Pushed by dkazakov into branch 'master'.

Bug 318347 grid brush keeps grid alignment when increasing brush size

This MR addresses a wishlist item to keep the grid alignment on the grid brush
when increasing the brush size. This introduces two new brush settings "Grid width"
and "Grid height" while removing the "scale" setting. This is to set exactly what
the size of each cell in the grid is instead of it being determined by the size of
the brush.

Test Plan
---------
1. Select a grid brush and draw a stroke
2. Increase brush size
3. Draw a new stroke. The ellipses in both strokes should keep alignment
   and be the same size

M  +25   -12   plugins/paintops/gridbrush/kis_grid_paintop.cpp
M  +1    -0    plugins/paintops/gridbrush/kis_grid_paintop.h
M  +6    -6    plugins/paintops/gridbrush/kis_grid_paintop_settings.cpp
M  +27   -1    plugins/paintops/gridbrush/kis_gridop_option.cpp
M  +16   -1    plugins/paintops/gridbrush/kis_gridop_option.h
M  +54   -41   plugins/paintops/gridbrush/wdggridoptions.ui

https://invent.kde.org/graphics/krita/commit/8aee6371a57b580034b016ce983f36b33e730835