Bug 318190 - Translations missing
Summary: Translations missing
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Unmaintained
Component: general (show other bugs)
Version: 0.6.0
Platform: Other Linux
: NOR major
Target Milestone: 0.6.1
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-11 13:24 UTC by Daimonion
Modified: 2013-04-12 17:25 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 0.6.1
Sentry Crash Report:


Attachments
Translations missing (466.69 KB, image/png)
2013-04-11 13:24 UTC, Daimonion
Details
KDE IM log viewer, also. (63.01 KB, image/png)
2013-04-11 13:30 UTC, Daimonion
Details
Text-ui kcm and chat window right-click context (328.58 KB, image/png)
2013-04-11 13:37 UTC, Daimonion
Details
Join chat room dialog and Presence applet right click context menu (179.04 KB, image/png)
2013-04-11 13:43 UTC, Daimonion
Details
Contacts plasmoid (82.87 KB, image/png)
2013-04-11 13:43 UTC, Daimonion
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daimonion 2013-04-11 13:24:01 UTC
Parts of the interface translation are missing.

I hope eveyrthing is clear from the picture below.
Comment 1 Daimonion 2013-04-11 13:24:48 UTC
Created attachment 78801 [details]
Translations missing
Comment 2 Daimonion 2013-04-11 13:30:29 UTC
Created attachment 78804 [details]
KDE IM log viewer, also.

KDE IM log viewer, also.
Comment 3 Daimonion 2013-04-11 13:37:41 UTC
Created attachment 78806 [details]
Text-ui kcm and chat window right-click context
Comment 4 Daimonion 2013-04-11 13:43:04 UTC
Created attachment 78808 [details]
Join chat room dialog and Presence applet right click context menu
Comment 5 Daimonion 2013-04-11 13:43:48 UTC
Created attachment 78809 [details]
Contacts plasmoid
Comment 6 David Edmundson 2013-04-11 13:45:36 UTC
I think we have a mixture of bugs and just some translations being missing which isn't our fault.

I would like someone to check all the above with x-test.
It does look like ktp-common-internals .po file isn't being loaded
Comment 7 Daimonion 2013-04-11 13:50:21 UTC
David, this is Serbian translation, and if it is to believe this graph here:
http://i18n.kde.org/stats/gui/trunk-kde4/team/sr/extragear-network/
everything is translated.
Comment 8 David Edmundson 2013-04-11 13:53:29 UTC
That's very useful, thanks.

There's still the possibility these translations were done between us making the 0.6.0 tarballs and now.
Comment 9 Daimonion 2013-04-12 13:22:09 UTC
I've just checked manually and it seems that po files for ktp-desktop-applets aren't updated for 0.6.0 release. This could be the cause of the problems for other parts of the kde-telepathy, too.

Perhaps there's a problem with ".Messages" script?
Comment 10 David Edmundson 2013-04-12 14:29:47 UTC
Translations for common-internals aren't being loaded.

i18n is auto loaded when the .pot file matches the name of the library.

This is not the case here ktp-common-internals
does not match:
ktpcommoninternalsprivate
ktpwidgetsprivate
ktpmodelsprivate

I don't know how to fix this properly.
Comment 11 Daniel Vrátil 2013-04-12 17:18:27 UTC
Git commit ae56f6c10f3cdedbe8088c71c24b555531b25b8d by Dan Vrátil.
Committed on 12/04/2013 at 19:15.
Pushed by dvratil into branch 'kde-telepathy-0.6'.

Load translation catalog and fix use of i18n in global scope

In order for KLocale to work, i18n() must not be used
in global static variables, because these are initialised
before KLocale. Use I18N_NOOP instead to mark the string
for translation and use i18n to perform the actual
lookup of the translated string only before displaying
the string to user.

Reviewed-By: David Edmundson
FIXED-IN: 0.6.1

M  +2    -0    CMakeLists.txt
M  +1    -0    KTp/CMakeLists.txt
M  +1    -0    KTp/Declarative/CMakeLists.txt
M  +1    -0    KTp/Models/CMakeLists.txt
M  +1    -0    KTp/Widgets/CMakeLists.txt
M  +12   -10   KTp/contact-info-dialog.cpp
A  +24   -0    global.cpp     [License: LGPL (v2+)]

http://commits.kde.org/telepathy-common-internals/ae56f6c10f3cdedbe8088c71c24b555531b25b8d
Comment 12 David Edmundson 2013-04-12 17:19:37 UTC
@Mladen Pejaković  we've fixed the core issue that should affect a lot of the stuff above.

when we release 0.6.1 you'll get all the current updates and this, please re-open if some part is not fixed.
Comment 13 Daimonion 2013-04-12 17:25:34 UTC
Thank you.