Bug 318102 - Rich text approver notifications can be trimmed with unclosed tags
Summary: Rich text approver notifications can be trimmed with unclosed tags
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Frameworks and Libraries
Component: approver (show other bugs)
Version: 0.6.0
Platform: Other Linux
: NOR normal
Target Milestone: Future
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-09 18:51 UTC by Martin Klapetek
Modified: 2013-04-09 18:54 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 0.6.1


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Klapetek 2013-04-09 18:51:04 UTC
We simply cut the string at the nearest space around 170th char. If there are open tags before it, this will produce an invalid html string, which is passed to KNotification.
Comment 1 Martin Klapetek 2013-04-09 18:54:05 UTC
Git commit 348ceeae309faf2a790077db52df15b872734ddd by Martin Klapetek.
Committed on 09/04/2013 at 20:53.
Pushed by mklapetek into branch 'kde-telepathy-0.6'.

Don't truncate the notification text

The QML notification plasmoid now takes care of proper elipsis, so we
don't need this anymore.

Reviewed-by: David Edmundson
FIXED-IN: 0.6.1

M  +1    -9    src/textchannelapprover.cpp

http://commits.kde.org/telepathy-approver/348ceeae309faf2a790077db52df15b872734ddd