Bug 317938 - Unused libs linked in Telepathy Logger Qt
Summary: Unused libs linked in Telepathy Logger Qt
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Unmaintained
Component: telepathy-logger-qt (show other bugs)
Version: git-latest
Platform: Other Linux
: NOR normal
Target Milestone: Future
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-06 16:29 UTC by David Edmundson
Modified: 2013-04-11 15:19 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Edmundson 2013-04-06 16:29:25 UTC
Kubuntu are applying this patch and want to upstream it

--- a/TelepathyLoggerQt4/CMakeLists.txt
+++ b/TelepathyLoggerQt4/CMakeLists.txt
@@ -177,9 +177,6 @@
     ${GOBJECT_LIBRARIES}
     -lgio-2.0
     ${QT_QTDBUS_LIBRARY}
-    ${DBUS_LIBRARIES}
-    ${LIBXML2_LIBRARIES}
-    ${DBUS_GLIB_LIBRARIES}
     ${TELEPATHY_GLIB_LIBRARIES}
     ${TELEPATHY_LOGGER_LIBRARIES}
     ${TELEPATHY_QT4_LIBRARIES}


Dan can you check this makes sense.
Talk to Quintasan and Rohan.
Comment 1 Daniel Vrátil 2013-04-08 12:26:28 UTC
Builds fine here. ldd reports them as unused as well, so I think it's fine:

$ ldd -u -r libtelepathy-logger-qt4.so
Unused direct dependencies:
        /lib64/libdbus-1.so.3
        /lib64/libxml2.so.2
        /lib64/libdbus-glib-1.so.2
        /lib64/libQtNetwork.so.4
        /lib64/libQtXml.so.4
        /lib64/libm.so.6

(QtXml and QtNetwork and dragged in probably by TelepathyQt4, so we can't get rid o these) 

For me, ship it.
Comment 2 Martin Klapetek 2013-04-11 15:19:40 UTC
Git commit 5142bd78d8a0f208e6d57be212380459a739f13b by Martin Klapetek.
Committed on 11/04/2013 at 17:19.
Pushed by mklapetek into branch 'master'.

Don't link against unneeded libs

Reviewed-by: Dan Vratil

M  +0    -3    TelepathyLoggerQt4/CMakeLists.txt

http://commits.kde.org/telepathy-logger-qt/5142bd78d8a0f208e6d57be212380459a739f13b