Bug 317782 - Vertical scrollbar always shown
Summary: Vertical scrollbar always shown
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Unmaintained
Component: text-ui (show other bugs)
Version: 0.6.0
Platform: Other Linux
: NOR normal
Target Milestone: Future
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-03 14:39 UTC by Antonio Rojas
Modified: 2013-04-03 15:35 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 0.7.0
Sentry Crash Report:


Attachments
Updated patch (replaced tabs with spaces, capitalized file name) (924 bytes, patch)
2013-04-03 15:31 UTC, Antonio Rojas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Rojas 2013-04-03 14:39:20 UTC
As long as there is any text at all in the messages window, a vertical scrollbar is shown, even if the contents fit in the visible window space. 

Reproducible: Always
Comment 1 David Edmundson 2013-04-03 14:41:06 UTC
We have had a pat ch in reviewboard for absolutely ages[1],  I needed someone to test it with multiple different themes. No-one has yet.

If someone could do so, we can ship it.

[1] https://git.reviewboard.kde.org/r/102005/
Comment 2 Antonio Rojas 2013-04-03 15:08:17 UTC
The patch fails to apply to 0.6.0 (could be because of tabs vs spaces?)
Comment 3 Antonio Rojas 2013-04-03 15:24:16 UTC
After replacing tabs with spaces the patch applies correctly, and it fixes the issue for me (tested with a both themes and a few variants). The scrollbar flashes on and off when reducing the window, but that's a different issue I guess (and less noticeable)
Comment 4 David Edmundson 2013-04-03 15:26:44 UTC
Could you upload your patch then please.
Comment 5 Antonio Rojas 2013-04-03 15:31:27 UTC
Created attachment 78611 [details]
Updated patch (replaced tabs with spaces, capitalized file name)
Comment 6 David Edmundson 2013-04-03 15:33:08 UTC
Thanks, I'd like to see this tested on more than the 2 default themes. 
I'll apply this as-is now into master, so we have from now until 0.7.0 for any bug reports. If it causes problems I can remove it.
Comment 7 David Edmundson 2013-04-03 15:35:27 UTC
Git commit 9f70a5428dbb66aff1770c0c4a95de31cacf6c0e by David Edmundson, on behalf of Paolo Capriotti.
Committed on 03/04/2013 at 17:34.
Pushed by davidedmundson into branch 'master'.

Fixed bug where the chat window was slightly scrollable even when it fitted in the window.

REVIEW: 102005

M  +4    -2    data/Template.html

http://commits.kde.org/telepathy-text-ui/9f70a5428dbb66aff1770c0c4a95de31cacf6c0e