Around the time of KDE4.5, kholiday's holiday.cpp was rewitten and split into holiday.cpp and holidayregion.cpp, compare: http://api.kde.org/4.5-api/kdepimlibs-apidocs/kholidays/html/holidayregion_8cpp_source.html with: http://api.kde.org/4.4-api/kdepimlibs-apidocs/kholidays/html/holidays_8cpp_source.html The long and the short of it, is that for the settings we should be using region codes rather than locations. Reproducible: Always Steps to Reproduce: 1. Use KMyMoney on a locale like United Kingdom 2. Schedule a transaction to fall on a public holiday (e.g. 1st April 2013 or 6th May 2013) with non-processing option set to next day. 3. Look at upcoming payments page. Actual Results: Schedule shows payment as falling on public holiday. Expected Results: Schedule shows payment as falling on day following public holiday.
Created attachment 78543 [details] Fix holiday region for KDE 4.5.0+ This patch: * Makes use of new HolidayRegion API to generate list of regions with languages for holiday region selector in schedule settings pane. What this patch doesn't do: * Check that current setting is a valid region.
Just to mention that I'm on KDE 4.6.5 with KMyMoney holiday calendar set to United Kingdom and my schedules for 1st April have moved to 2nd April as I expect. I'm not sure why but I don't see the problem described by Ian.
(In reply to comment #2) > Just to mention that I'm on KDE 4.6.5 with KMyMoney holiday calendar set to > United Kingdom and my schedules for 1st April have moved to 2nd April as I > expect. I'm not sure why but I don't see the problem described by Ian. I'm on KDE 4.10.1, presumably at some point between 4.5 and 4.10 backwards compatibility was removed.
(In reply to comment #1) > Created attachment 78543 [details] > Fix holiday region for KDE 4.5.0+ > > This patch: > * Makes use of new HolidayRegion API to generate list of regions with > languages for holiday region selector in schedule settings pane. > > What this patch doesn't do: > * Check that current setting is a valid region. Another option would be to use the new HolidayRegionSelector widget.
(In reply to comment #2) > Just to mention that I'm on KDE 4.6.5 with KMyMoney holiday calendar set to > United Kingdom and my schedules for 1st April have moved to 2nd April as I > expect. I'm not sure why but I don't see the problem described by Ian. I'm on KDE 4.9.5 and, like Dave, get the correct results, without the patch. I've not taken particular note in the past of this feature's working.
(In reply to comment #5) > (In reply to comment #2) > > Just to mention that I'm on KDE 4.6.5 with KMyMoney holiday calendar set to > > United Kingdom and my schedules for 1st April have moved to 2nd April as I > > expect. I'm not sure why but I don't see the problem described by Ian. > > I'm on KDE 4.9.5 and, like Dave, get the correct results, without the patch. > I've not taken particular note in the past of this feature's working. Well for KDE 4.10.1 upwards running on Fedora 17/18 x64, it definitely is required.
(In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #2) > > > Just to mention that I'm on KDE 4.6.5 with KMyMoney holiday calendar set to > > > United Kingdom and my schedules for 1st April have moved to 2nd April as I > > > expect. I'm not sure why but I don't see the problem described by Ian. > > > > I'm on KDE 4.9.5 and, like Dave, get the correct results, without the patch. > > I've not taken particular note in the past of this feature's working. > > Well for KDE 4.10.1 upwards running on Fedora 17/18 x64, it definitely is > required. Not doubting you, Ian, just responding to your comment on Reviewboard about checking on other revs.
Compiled ok and tested ok on both KDE 4.6.5 and 4.8.5 which are the two versions I have access to. I don't have an id for reviewboard so haven't comments updated there.
commit 795dfb4a9e158ea1ed2fef59d48c25f341c65a90