Bug 317572 - D-Bus Notification should always be rendered as Rich Text
Summary: D-Bus Notification should always be rendered as Rich Text
Status: RESOLVED WORKSFORME
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: knotify (show other bugs)
Version: Git
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Olivier Goffart
URL: http://picpaste.com/t-hawk_notify-lOc...
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-29 23:14 UTC by Uwe L. Korn
Modified: 2023-02-01 05:05 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Quickfix in KPassivePopup to force Rich Text rendering (539 bytes, patch)
2013-03-29 23:37 UTC, Uwe L. Korn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Uwe L. Korn 2013-03-29 23:14:20 UTC
Notifications received via D-Bus may support a certain subset of HTML as markup. KNotify reports the capability that it supports markup. If the notification text contains line breaks and markup is not used in the first line, the text is used as plain text whereas it should be rendered as rich text. 

In the provided link the upper notification contains line breaks and is rendered as plain text and the lower one achieves line breaks through <br />'s which is non-standard (and not supported by a lot window managers) is correctly rendered as it should look for the above one.

The main problem is that QLabel auto-detects if a text should be rendered as rich text using only the text in front of the first line break. If the notification does not include markup in the first line, it is rendered as plain text though having markup in a following line.

Reproducible: Always
Comment 1 Uwe L. Korn 2013-03-29 23:20:31 UTC
As I am not a KDE user, I can't reproduce it myself (I'm just a developer confronted with this bug in KDE), but the following should trigger the bug:
https://gist.github.com/xhochy/965d5a767f2fe2e93f55
Comment 2 Uwe L. Korn 2013-03-29 23:37:09 UTC
Created attachment 78494 [details]
Quickfix in KPassivePopup to force Rich Text rendering

This patch shows a starting point how/where to force RichText rendering for the Notifications.
Comment 3 Christoph Feck 2013-04-01 11:12:47 UTC
The image and the patch do not match. In the image, it shows plasma notifications, which are probably fixed with https://git.reviewboard.kde.org/r/109492/
Comment 4 Uwe L. Korn 2013-04-01 12:12:46 UTC
The attachted patch was a very rude quickfix to show the correct behaviour, not a suggestion for merge ;)

The patch in https://git.reviewboard.kde.org/r/109492/ looks like it is doing the right thing (forcing RichTextRendering)
Comment 5 Andrew Crouthamel 2018-11-10 03:15:47 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 6 Andrew Crouthamel 2018-11-20 04:09:36 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!
Comment 7 Justin Zobel 2023-01-02 02:04:19 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 8 Bug Janitor Service 2023-01-17 05:15:33 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 9 Bug Janitor Service 2023-02-01 05:05:02 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!