Bug 317511 - Allow transaction editing from ledger view after double-clicking on category in category list
Summary: Allow transaction editing from ledger view after double-clicking on category ...
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: general (show other bugs)
Version: git (master)
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-28 22:44 UTC by Moritz Bunkus
Modified: 2024-07-06 19:13 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.2
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Moritz Bunkus 2013-03-28 22:44:13 UTC
This is kmymoney 4.6.90-ddfff2c8af with KDE 4.10.1 (KDE itself was installed from Arch Linux packages, kmymoney is self-compiled from Git).

First, I go to the list of categories. From there I double-click on any category that has at least one transaction. kmymoney then shows me the list of all transactions in this category in the ledgers view. So far so good.

From this view it would be very, very helpful if I could actually edit the transactions shown. However, the context menu has "new" and "edit" disabled (I can "delete", "duplicate", "move...", "mark...", but that's not what I want).

My use case is editing quite a number of transactions that all belong to a certain category, to be more specific, to add information for myself in the memo field. This is rather cumbersome at the moment. I have to:

1. bring up the list of all transactions in the category as described above,
2. find the first one that I haven't modified yet,
3. go to the normal ledger view for the account the transaction was made from & find the transaction (at least there's an option for that in the context menu),
4. edit the transaction,
5. rinse & repeat.

Steps 2 and 3 are completely unnecessary and time-consuming, especially when you're talking about editing ~100 transactions. Therefore I'd like to be able to edit the transaction, or at least certain fields like the memo.

The same applies to the list of transactions them I'm coming from a payee.

Reproducible: Always

Steps to Reproduce:
See details.

1. Go to list of categories
2. Double-click on category
3. Select any transaction and realize you cannot edit it
Comment 1 allan 2013-03-28 23:56:29 UTC
On Thu, 28 Mar 2013 22:44:13 +0000
Moritz Bunkus <moritz@bunkus.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=317511
> 
>             Bug ID: 317511
>            Summary: cannot edit transaction from ledger view after
>                     double-clicking on category in category list
>     Classification: Unclassified
>            Product: kmymoney4
>            Version: git master
>           Platform: Compiled Sources
>                 OS: Linux
>             Status: UNCONFIRMED
>           Severity: minor
>           Priority: NOR
>          Component: general
>           Assignee: kmymoney-devel@kde.org
>           Reporter: moritz@bunkus.org
> 
> This is kmymoney 4.6.90-ddfff2c8af with KDE 4.10.1 (KDE itself was
> installed from Arch Linux packages, kmymoney is self-compiled from
> Git).
> 
> First, I go to the list of categories. From there I double-click on
> any category that has at least one transaction. kmymoney then shows
> me the list of all transactions in this category in the ledgers view.
> So far so good.
> 
> From this view it would be very, very helpful if I could actually
> edit the transactions shown. However, the context menu has "new" and
> "edit" disabled (I can "delete", "duplicate", "move...", "mark...",
> but that's not what I want).
> 
> My use case is editing quite a number of transactions that all belong
> to a certain category, to be more specific, to add information for
> myself in the memo field. This is rather cumbersome at the moment. I
> have to:
> 
> 1. bring up the list of all transactions in the category as described
> above, 2. find the first one that I haven't modified yet,
> 3. go to the normal ledger view for the account the transaction was
> made from & find the transaction (at least there's an option for that
> in the context menu), 4. edit the transaction,
> 5. rinse & repeat.
> 
> Steps 2 and 3 are completely unnecessary and time-consuming,
> especially when you're talking about editing ~100 transactions.
> Therefore I'd like to be able to edit the transaction, or at least
> certain fields like the memo.
> 
> The same applies to the list of transactions them I'm coming from a
> payee.
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> See details.
> 
> 1. Go to list of categories
> 2. Double-click on category
> 3. Select any transaction and realize you cannot edit it
> 

I think I've just achieved this.

Go to the appropriate account ledger.  Enter into the search box, the
category you want and you should now see them listed.  Select several
or all and they seem to be editable.  Enter a distinctive memo, and I
think you'll need to enter the category in order to get the Enter
button.  Now click Enter and, as a check, into the search box enter the
distinctive memo, and you should see a list of the ones you edited.

Allan
Comment 2 Moritz Bunkus 2013-03-29 10:36:00 UTC
What you're describing is a workaround, not a solution. It also only works for unique category names. It doesn't work too well e.g. if you have both liability and asset categories with the same name (e.g. "Taxes" or "Presents" or whatever).

It also doesn't work too well if the category name appears in memo fields of transactions not belonging to that category. The ledger list view doesn't make it easy too tell a transaction's category until you click on it: there's no "category" column, so you can only see the category in the transaction details view at the bottom after having clicked on it.

I get why you cannot edit a transaction freely from the category transaction list ( = from the ledgers view after having double-clicked on a category in the list of categories). If you'd edit e.g. the payee of a split transaction then you'd also change the other splits that belong to the same transaction, no matter if they belong to a different category. Might be very confusing to the user.

However, you can already change such a transaction's category by using "Move to..." from the context menu. The memo itself is also a field that's actually unique to this split. So why not make the transaction editable but only allow changing these two fields (category and memo)?
Comment 3 algolix 2013-04-11 08:21:49 UTC
I didn't open new bug, but i have some related bugs.

1. About allan's search workaround. Search uses only lowest category to
compare strings. E. g. i have such tree:

* Car
  ** Fuel
  ** Repair
  ** Insurance

If i input "Car" into the search bar, i get only "caramel" from other
category.
 
2. When i select some "node" element (not root, not list, like Car) without 
records in the Categories (by double click) i get empty list in the Ledgers. 
Looks like bug, not feature. I expect to see all records from "Car" tree.

3. When i select some "list" element in the Categories (by double click) i
get expected list in the Ledgers.  But how can i return to the full list in
the Ledgers tab?! Root element in the Categories doesn't work (i mean double
click to the root element).  Well, after some exit-start cycles if found
solution: reselect selected (!) "account" in combo box on Ledgers tab...
 

I have version 4.6.2 on the KDE 4.8.4 (4.8.4), 
Linux 3.2.0-4-686-pae #1 SMP Debian 3.2.41-2 i686 GNU/Linux
Comment 4 allan 2013-04-21 10:14:23 UTC
I'm posting a couple of messages from the list, which, towards the end, relate to editing transactions selected via Category view.  To summarise, it may be possible to remove this restriction, but only when more developer time is available.
"
> Thomas Baumgart <thb@net-bembel.de> wrote:  
> > Hi Allen et al,
> > 
> > On Thursday 18 April 2013 12:20:47 aga wrote:  
> > > While investigating the reason why it was not possible to edit
> > > multiple investment transactions, I noticed that there was quite a
> > > number of tooltips in the code that appeared to be non-functional.
> > > For instance, if one of the transactions involved a closed account,
> > > or if the chosen transactions were not of the same type.  In those
> > > cases, and others, editing was disabled, but no tooltip appeared on
> > > the transactions to explain.
> > > 
> > > I was expecting the tooltip to appear this way, in the same way
> > > that a missing category/account assignment is flagged.  So, I
> > > implemented a fairly simple way to achieve that.  Then, I noticed
> > > that, having deliberately selected two transactions that were not
> > > of the same type, the Edit button was correctly disabled, but,
> > > provided one first clicked in the body of the transactions view, a
> > > tooltip did appear, on the Edit button, although with an invalid
> > > message indicating 'Duplicate the current selected transactions'.
> > > 
> > > What I'm suggesting is to combine the two methods, one which gives a
> > > more obvious hint, and the other, existing one, which might still
> > > have a valid purpose.
> > > 
> > > Any thoughts, anyone?  
> > 
> > More and more I get the feeling, that this whole ledger business
> > comes to ages. Many things have been put in there and you stepped on
> > another one of those features. They are around since the KDE3 days
> > and might not have been ported to their full functioning into KDE4. I
> > don't want to blame anyone who worked on the KDE4 port as this was a
> > large job by itself.
> > 
> > Before putting any more effort into getting the existing stuff
> > working, I suggest to re-work the whole ledger view to be based on
> > the MVC paradigm and use the existing Qt4 mechanisms more
> > effectively. I expect a performance boost of the ledger view as a
> > side effect, btw.
> > 
> > Just my 0.02  
> 
> Not any time soon, though, I suspect?
> 
> What about other ledger area issues?  eg.
> https://bugs.kde.org/show_bug.cgi?id=317511 , although the question
> about being able to edit transactions selected via Category view may
> not be a Ledger issue.  What is the rationale for this restriction?  

I think we introduced this restriction way back in the 3.x days for usability 
reasons. All of us did not understand accounting principles too well then 
(which fortunately has changed due to the work on this project) and always had 
the vision that one needs an account to move money. Well, today we know that 
categories are simply accounts as well accounting wise and could probably lift 
that restriction. But we would have to check all the UI stuff that is still 
based on the restriction. Since the ledger view is the area that is affected 
the most by such a change and my feeling about a rewrite (see above) of that 
view lets me postpone the introduction of that feature for now.
Comment 5 Cristian Oneț 2014-09-24 07:42:12 UTC
I'm moving this to the wishlist.
Comment 6 Jack 2023-07-09 23:01:52 UTC
I just stumbled on this, and as I understand things, there is currently good and bad news.  This is clearly still not possible in 5.1.  However, in git master, the ledger view for a category does allow editing transactions.  However, editing multiple transactions in the ledger (whether for a regular account or a category) is not yet implemented.  However, it is something likely to be done either by the time the code in master branch is released for production, or shortly thereafter, so it is definitely not ignored.
Comment 7 Jack 2024-07-06 18:31:50 UTC
Are we ready to call this closed and fixed in 5.2?