Bug 317211 - Standard XMLGUI menubar menus are forgotten if not filled on first createGui()
Summary: Standard XMLGUI menubar menus are forgotten if not filled on first createGui()
Status: RESOLVED WORKSFORME
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: kdeui (show other bugs)
Version: 4.10.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-22 23:03 UTC by Friedrich W. H. Kossebau
Modified: 2023-01-30 05:07 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Friedrich W. H. Kossebau 2013-03-22 23:03:13 UTC
Braindump has had the problem that the menu "view" has been only appended behind the "help" menu, even if explicitely listed in "braindumpui.rc", while the menu "edit" and a custom menu "Shapes" have been at the right place.

It was found that this was due to the fact that the menu "edit" got filled with actions already when createGui() was called in the main app, while the menus "view" and "Shapes" were only filled on the call of addClient() with another XMLGUI client-based plugin.

So if a client is added which uses standard menus even if the main shell does not use them, I would expect that in that case the standard menus are inserted at the place as defined in the standard, and not behind the last standard menu ("help").

The workaround I chose for now is to list the menu "view" also in the braindumpui.rc, adding some dummy entry to it (<Separator/> or <DefineGroup name="dummyToKeepViewMenu"/> work for this).

Reproducible: Always




--- 8< braindumpui.rc ---
<!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
<kpartgui name="braindump" version="0">
    <MenuBar>
        <Menu name="edit" >
        </Menu>
        <Menu name="Shapes" >
            <Text context="@title:menu">Shapes</Text>
        </Menu>
        <Menu name="view" >
        </Menu>
    </MenuBar>
</kpartgui>
--- 8< ---


--- 8< braindumpplugin.rc ---
<!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
<kpartgui name="braindump" version="0">
    <MenuBar>
        <Menu name="Shapes" ><Text>Shapes</Text>
            <Action name="shapes_duplicate" />
            <Action name="shapes_group"/>
            <Action name="shapes_ungroup"/>
        </Menu>
        <Menu name="view">
            <Action name="zoom_out"/>
            <Action name="zoom_in"/>
            <Action name="view_zoom"/>
        </Menu>
    </MenuBar>
--- 8< ---
Comment 1 Andrew Crouthamel 2018-11-10 03:17:47 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 2 Andrew Crouthamel 2018-11-20 03:57:42 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!
Comment 3 Justin Zobel 2022-12-31 00:24:24 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 4 Bug Janitor Service 2023-01-15 05:11:07 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Bug Janitor Service 2023-01-30 05:07:47 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!