Bug 317073 - Request to add fade transition to presentation mode
Summary: Request to add fade transition to presentation mode
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2013-03-20 12:23 UTC by Yassine SAKOUM
Modified: 2015-11-05 14:37 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yassine SAKOUM 2013-03-20 12:23:22 UTC
HI, i whould like to to have fade transition for presentation mode. I think it's more suitable for  presentations rather than all the transitions available currently in Okular.

Reproducible: Always
Comment 1 Prakhar Mohan 2013-03-22 09:15:17 UTC
Hi. I would like to take up this bug. How to go about it>
(In reply to comment #0)
> HI, i whould like to to have fade transition for presentation mode. I think
> it's more suitable for  presentations rather than all the transitions
> available currently in Okular.
> 
> Reproducible: Always
Comment 2 Albert Astals Cid 2013-03-22 19:07:37 UTC
Download the code, try to look where/how the other transition effects are done, do the new one
Comment 3 Stephan Burkhardt 2013-03-25 12:22:53 UTC
Maybe as long as we don't have a fade transition, the transitions could be removed alltogether? They clutter up the options menu (admittedly not too much) and I doubt that anyone is still using these Office2000 style transitions nowadays. I only went through a couple of them, but they all looked IMHO very tacky and cheap.

I don't want to go all "Interface-Nazi", but I seriously doubt anyone is seriously using the transitions, so removing them at least from the options dialogue would make it more clear and approachable.

Here is probably the wrong place for a discussion. Should I file this as a new wishlist bug?
Comment 4 Albert Astals Cid 2013-03-25 12:31:32 UTC
@Stephan: The PDF spec specifies those transitions so we're not removing them. You can go and argue with them.
Comment 5 Stephan Burkhardt 2013-03-25 15:00:33 UTC
@4 Well, then nevermind :)

I still think that exposing these transitions in the options dialogue is not necessary (even if they are implemented for pdfs that request them), but I understand that this is not really of any importance.

Thanks for the swift answer, btw.
Comment 6 Yassine SAKOUM 2013-10-17 01:05:30 UTC
(In reply to comment #1)
> Hi. I would like to take up this bug. How to go about it>

@Prakhar Mohan
Did you make any progress on the fade transition ?
Comment 7 Prakhar Mohan 2013-10-17 05:55:02 UTC
No, sadly I did not.
Comment 8 Saheb Preet Singh 2014-01-24 08:51:26 UTC
can I also try to solve this bug???
Comment 9 Albert Astals Cid 2014-01-24 18:03:34 UTC
sure
Comment 10 Gagan Batra 2014-02-01 12:01:32 UTC
 Hello,
Can I contribute to this bug ?
Comment 11 Albert Astals Cid 2014-02-01 13:03:54 UTC
Please, do not ask the same question in two places, having two discussions going at one over the same thing (mailing list and here) is not a good thing since it makes it much harder to follow the discussion.

As if you can work on this or not, you can work on whatever you want, it's your time, so we're not going to tell you how to use it :-)

Now. Saheb said he wanted to try fixing it so it may be better if you find something else to work on not to duplicate efforts. But on the other hand you could also collaborate on it, or you both implement it and we choose the better solution. So as you said, it's your time, do what you think it's better for you :-)

Saheb can you confirm you're still working on trying to implement this?
Comment 12 Saheb Preet Singh 2014-02-04 08:08:43 UTC
(In reply to comment #11)

> Saheb can you confirm you're still working on trying to implement this?

Yes I am working on this bug but gagan you are also invited to solve the bug
Comment 13 sahil 2015-03-29 13:57:36 UTC
I reviewed your review-board patch and it was really cool. Can you please tell if there is something left in this bug so that i can also contribute?
Moreover if this fade transition is successfully applied shall i move towards other transitions which are still to be implemented?
Comment 14 Saheb Preet Singh 2015-03-30 10:20:48 UTC
(In reply to sahil from comment #13)
Hi,
> I reviewed your review-board patch and it was really cool. Can you please
> tell if there is something left in this bug so that i can also contribute?
The patch is near its commit. You can test the patch and find out if anything is not working properly or breaking some thing or if anything is missing in the transition. You can also re-implement the patch, if you can implement it in a better way.
> Moreover if this fade transition is successfully applied shall i move
> towards other transitions which are still to be implemented?
Hmm, the transition is not patched successfully, yes you can implement the missing transitions. :)
Comment 15 sahil 2015-04-03 18:52:38 UTC
Well i am trying to implement the Push transition. Do i need to report another bug like this fade transition one or it will be fine if i keep continuing my work and share updates through this bug only?
Comment 16 Albert Astals Cid 2015-04-03 20:47:18 UTC
Use reviewboard
Comment 17 Albert Astals Cid 2015-07-16 23:03:01 UTC
Git commit 48905cf16b3186ce813d766a77905c8260493480 by Albert Astals Cid, on behalf of Saheb Preet Singh.
Committed on 16/07/2015 at 23:02.
Pushed by aacid into branch 'master'.

Support Fade transition in presentation mode

REVIEW: 115532

M  +5    -0    conf/dlgpresentationbase.ui
M  +1    -0    conf/okular.kcfg
M  +69   -12   ui/presentationwidget.cpp
M  +4    -0    ui/presentationwidget.h

http://commits.kde.org/okular/48905cf16b3186ce813d766a77905c8260493480