Bug 316611 - Clear error messages when connecting fails
Summary: Clear error messages when connecting fails
Status: RESOLVED UNMAINTAINED
Alias: None
Product: bodega
Classification: Applications
Component: Plasma Active client (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR grave
Target Milestone: ---
Assignee: Aaron J. Seigo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-12 17:48 UTC by Thomas Pfeiffer
Modified: 2018-09-02 21:49 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Pfeiffer 2013-03-12 17:48:20 UTC
When I go to Add Ons, tap "I already have an account", enter my credentials and tap "Connect!", the dialog slides out, only to be replaced by the same dialog, without any error message being displayed.
This shows two problems:
1. I cannot connect, even though the credentials were correct afaik
2. There is no error message, so I cannot even tell what went wrong

Reproducible: Always

Steps to Reproduce:
1. Open Add Ons
2. Tap "I already have an account"
3. Enter credentials
4. Tap "Connect"
Actual Results:  
Same dialog is presented again, with empty fields

Expected Results:  
The store is shown
Comment 1 Thomas Pfeiffer 2013-03-20 18:23:05 UTC
It's working again. Was that a bug in the code or a problem with the server? If it was a server-side problem which might happen again in the future, we absolutely need an error message for this. If it was a one-time problem which is fixed now, we can close this bug as fixed.
Comment 2 Giorgos Tsiapaliokas 2013-03-20 18:45:20 UTC
the issue was that the server was down.

I can't be 100% sure what caused this one, but I assume that it was us(me and Antonis).
Last week we were doing some tests with the bodega-server for the bodega webapp client.

The server failed because stripe(as stripe.com) changed the API, so the node module automatically changed the API that we use in the bodega-server.
So node.js failed because there was a syntax issue. [1]

The issue has been fixed with this review 
https://git.reviewboard.kde.org/r/109498/

What we can do is to wait x seconds and if the active client doesn't get a response from the
bodega server to show a dialog.

[1] A few more technical details,
the stripe node module internally it does a http request which takes a json and it converts it into a
javascript object, so when the API changed we where trying to access a property of a javascript object which didn't exist and the server went down.
Comment 3 Thomas Pfeiffer 2013-03-20 18:50:25 UTC
Yes, an error message if the server does not respond would definitely be important. If you press "Connect!" and simply nothing happens, you cannot tell whether something is wrong with the server or with the client or if you simply have entered a wrong password.
So I'm keeping this bug open as a reminder that an error message has to be implemented, since the server not responding is something that may happen again in the future, for whatever reason.
Comment 4 Andrew Crouthamel 2018-09-02 21:49:40 UTC
Hello! Sorry to be the bearer of bad news, but this project has been unmaintained for many years and I will be closing this bug.