Bug 316580 - detail view does not honor mouse wheel scrolls by setting
Summary: detail view does not honor mouse wheel scrolls by setting
Status: RESOLVED DUPLICATE of bug 295571
Alias: None
Product: dolphin
Classification: Applications
Component: view-engine: details mode (show other bugs)
Version: 2.1
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-12 09:02 UTC by Martin Koller
Modified: 2013-10-30 09:31 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
fix scrolling (812 bytes, patch)
2013-10-10 21:54 UTC, Laurence
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Koller 2013-03-12 09:02:31 UTC
In systemsettings -> Mouse -> Advanced there is a setting "Mouse wheel scrolls by x lines", which I have set to 3.
However in details view of a directory in konqueror when I scroll with the mouse wheel the view scrolls 7 lines when I just scroll the wheel by one tick.
This makes viewing/searching very annoying since the line I'm looking at suddenly scrolls out of my view and I do not easily see where I am now.

Reproducible: Always
Comment 1 Frank Reininghaus 2013-03-12 09:35:37 UTC
Thanks for the report. Yes, it seems that we currently don't consider that setting. I'm not quite sure how to fix it though. We certainly don't want to scroll by 3 lines in Icons View for each wheel step... The problem is that the code that determines the "scroll distance" in 

KtemListContainer::wheelEvent(QWheelEvent* event)

is currently unaware of the view mode, and I'm not really in favour of changing that. Adding cross-dependencies everywhere would only make future maintenance harder. Maybe we can add a virtual method to KItemListView that returns the scroll distance in "pixels per line" and override it in KStandardItemListView to have sensible values for each view mode.
Comment 2 Woodsman 2013-03-16 19:28:44 UTC
This bug affects me. I only use tree view and a single detente movement in the mouse wheel results in the file list moving by six or seven lines. Difficult to scroll through the file list when the wheel moves that much distance.

I have the mouse configured to scroll by 1 line.

I never had this problem previously. Perhaps a glance at older code might reveal something, even the older KDE 3 code?

Hopefully this can get fixed in 4.10.2? :)
Comment 3 Frank Reininghaus 2013-03-17 10:21:39 UTC
> Hopefully this can get fixed in 4.10.2? :)

Please note that we currently have 253 open bug reports and only an extremely small number of people who work on Dolphin in their free time. We cannot make any promises regarding bug fixing schedules.
Comment 4 Woodsman 2013-03-17 18:22:15 UTC
Yes, I know.  Just hoping. :)
Comment 5 Frank Reininghaus 2013-04-26 12:58:45 UTC

*** This bug has been marked as a duplicate of bug 295571 ***
Comment 6 Laurence 2013-10-10 21:54:11 UTC
Created attachment 82780 [details]
fix scrolling

Well, here's my first patch, hope you like it :)
It makes the scrolling adhere to the settings, if that results in a smaller scroll than the old 1/4 of the view. This fixes the main view, but not the side panels, which don't seem to have view->itemSize() set to something useful. So that gets the old behavior.
Comment 7 Frank Reininghaus 2013-10-13 17:36:57 UTC
(In reply to comment #6)
> Created attachment 82780 [details]
> fix scrolling

Thanks for the patch! Could you please submit it to http://git.reviewboard.kde.org/? On ReviewBoard, it's much easier to discuss patches, and it also enables other people to comment on the patch (only few people follow all bug reports for one "product").

Thanks for your help.
Comment 8 Frank Reininghaus 2013-10-30 09:31:34 UTC
@Laurence: I see that you were not CC'ed to this report, so you might not have seen my last comment. It would be great if you could submit your patch to ReviewBoard. Thanks!