Bug 316323 - %senderPrefix% appears in some adium themes
Summary: %senderPrefix% appears in some adium themes
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Unmaintained
Component: text-ui (show other bugs)
Version: git-latest
Platform: Other Linux
: NOR normal
Target Milestone: Future
Assignee: Telepathy Bugs
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2013-03-07 16:02 UTC by Daniele E. Domenichelli
Modified: 2013-05-20 09:38 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 0.7.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniele E. Domenichelli 2013-03-07 16:02:07 UTC
According to some changelog:

%senderPrefix% now contains a textual representation (., @, %, +, or an empty string) of the user's status in a group chat. (#11882)

To test this you can check the iridium theme.
Comment 1 David Edmundson 2013-03-07 16:02:51 UTC
Is that even on the spec wiki page at all?
Comment 2 Daniele E. Domenichelli 2013-03-08 09:08:11 UTC
I couldn't find it in the wiki, but here's another link to the bug: https://trac.adium.im/ticket/11882
Adds the keyword %senderPrefix% which is substituted by the textual representation of the sender's current status in a chat (@ for op, + for voice, % for halfop, . for founder, and an empty string if none). Fixes #11882.

Since this seems to be irc specific, and afaik we are not supporting it at the moment, we could just replace it with an empty string. (perhaps add a comment with a link to this bug in case we want to add it later)
Comment 3 David Edmundson 2013-03-17 00:33:10 UTC
I see no reason for this to block 0.6.0.

If you want to fix this before 0.6 go for it, but I won't let this block the release, as long as our two main themes work.
Comment 4 David Edmundson 2013-05-20 09:38:20 UTC
Git commit b68526e4b643468c1483ddc6f946638cb7c558a1 by David Edmundson.
Committed on 20/05/2013 at 11:26.
Pushed by davidedmundson into branch 'master'.

Fix %senderPrefix% appearing in themes
FIXED-IN: 0.7.0
REVIEW: 110539

M  +4    -0    lib/adium-theme-view.cpp

http://commits.kde.org/telepathy-text-ui/b68526e4b643468c1483ddc6f946638cb7c558a1