Bug 316315 - make it compile with -Werror -std=c++11
Summary: make it compile with -Werror -std=c++11
Status: RESOLVED INTENTIONAL
Alias: None
Product: telepathy
Classification: Unmaintained
Component: general (show other bugs)
Version: git-latest
Platform: Other Linux
: NOR wishlist
Target Milestone: Future
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on: 316318 316320
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-07 15:24 UTC by Alin M Elena
Modified: 2013-12-11 23:21 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Alin M Elena 2013-03-07 15:24:34 UTC 
make all ktp components compile with 
-Werror -std=c++11

Reproducible: Always
Comment 1 Martin Klapetek 2013-11-15 09:29:10 UTC 
Agreed on the -Werror. Not really agreeing with enabling c++11 just yet. We'll do whatever kde-workspace does now.
Comment 2 Martin Klapetek 2013-11-15 09:57:31 UTC 
Git commit dcd35958416c14624213fea0523d417c5afd3b7c by Martin Klapetek.
Committed on 15/11/2013 at 09:57.
Pushed by mklapetek into branch 'master'.

Treat warnings as errors

M  +2    -0    CMakeLists.txt

http://commits.kde.org/telepathy-common-internals/dcd35958416c14624213fea0523d417c5afd3b7c
Comment 3 Martin Klapetek 2013-12-11 23:21:33 UTC 
I just got told by many people that including -Werror is evil and should never ever be done in public repos as the warnings may come from any headers we're using, which is currently the case of ktp-common-internals failing on QtGstreamer.

Reverting the change then and closing as WONTFIX.