Bug 316172 - Incoming highlighted messages have an extra line
Summary: Incoming highlighted messages have an extra line
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Frameworks and Libraries
Component: text-ui-message-filters (show other bugs)
Version: git-latest
Platform: Other Linux
: NOR normal
Target Milestone: 0.6.0
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-05 13:48 UTC by Daniele E. Domenichelli
Modified: 2013-03-06 13:00 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/telepathy-text-ui/cdb416c04da71881ee52d06a9a5147ebf2b64b3d
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Daniele E. Domenichelli 2013-03-05 13:48:04 UTC 
The extra <div> seems to be adding an extra line, see http://wstaw.org/m/2013/03/05/snapshot122.png
Comment 1 David Edmundson 2013-03-05 13:58:27 UTC 
This is either caused by the sendMessages filter OR by the patch to make the text-ui send message shortcut configurable. 

If someone could find out which patch breaks it, that would really help.
Comment 2 David Edmundson 2013-03-06 13:00:10 UTC 
Git commit cdb416c04da71881ee52d06a9a5147ebf2b64b3d by David Edmundson.
Committed on 06/03/2013 at 05:06.
Pushed by davidedmundson into branch 'master'.

Use theme to highlight messages

Rather than hardcoding red, pass a special messageClass to the theme which highlights it for us
Looks better, and is theme dependant.

REVIEW: 109309

M  +0    -6    filters/highlight/highlight-filter.cpp
M  +4    -0    lib/chat-widget.cpp

http://commits.kde.org/telepathy-text-ui/cdb416c04da71881ee52d06a9a5147ebf2b64b3d