Bug 315969 - optimise avatarPixmap()
Summary: optimise avatarPixmap()
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Unmaintained
Component: common-internals (show other bugs)
Version: git-latest
Platform: Other Linux
: NOR normal
Target Milestone: 0.6-next
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-01 17:59 UTC by Alin M Elena
Modified: 2013-03-02 18:56 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/telepathy-common-internals/baf35cca3abcdcb33f8af93b95f0cd5a60c83115
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Alin M Elena 2013-03-01 17:59:30 UTC 
<http://git.reviewboard.kde.org/r/109231/#comment21158>

    This all needs to go into a QPixmapCache.
    
    Otherwise it'll be run each time. You can use the use the avatarToken + "-offline" as the key.
    
    Files are implicitly cached, the output of this won't be.

Reproducible: Always
Comment 1 Alin M Elena 2013-03-02 10:06:58 UTC 
http://doc.qt.digia.com/qq/qq12-qpixmapcache.html
Comment 2 Alin M Elena 2013-03-02 18:56:12 UTC 
Git commit baf35cca3abcdcb33f8af93b95f0cd5a60c83115 by Alin M Elena.
Committed on 02/03/2013 at 19:54.
Pushed by elena into branch 'master'.

added caching for transformed avatars
REVIEW: 109240

M  +10   -2    KTp/contact.cpp
M  +1    -0    KTp/contact.h

http://commits.kde.org/telepathy-common-internals/baf35cca3abcdcb33f8af93b95f0cd5a60c83115