Bug 315621 - extracti18n.pl and i18ndata file suggestions
Summary: extracti18n.pl and i18ndata file suggestions
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: git master (please specify the git hash!)
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2013-02-22 11:32 UTC by margueritesu
Modified: 2014-04-02 17:27 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description margueritesu 2013-02-22 11:32:40 UTC
Hi, Krita dev,

I'm zh_CN translator of Krita.

Here's the case I met.

1. You have to git clone the whole "calligra" which is _huge_ and _slow_ to `extracti18n.pl > i18ndata`

2. the "i18ndata" file is useless for translators because it doesn't tell where the string is from.

3. you have to `grep -r "string" ./data` to find which brush/pattern file the string is located.

4. you have to open the .gih .gbr .pat to see how the file actually looks like

Then you can see how to translate the file properly. because "M_01" is really not a good name and translation.

So can you please:

1. modify "extracti18n.pl" to include the source path

2. place the generated better "i18ndata" file in git repo by default.

So translators can just view i18ndata online and get clear information.

3. use descriptive and unambiguous names for those .gih .gbr .pat files. 

eg: "Canvas Covered" is really not a good name in Krita. Because Krita itself uses "Canvas" as a functional reserved name. Since it's a .pat file, the file name should be "blue-white jeans with villus" if you open and view it in gimp.

eg1: "Pipe_01", it should be "iron_pipe_with_seamed_edge".

something like that. if you're a designer youself, you must agree that Krita will be more user-friendly if a tool tells _exactly_ what it can do other than just a numbered word.


Greetings 

Marguerite

Reproducible: Always
Comment 1 Halla Rempt 2013-03-31 11:18:28 UTC
Hi Marguerite,

Thanks for your input. We can't do much about the size of the git repo, I'm afraid, but your other suggestions are sound.
Comment 2 animtim 2013-12-02 16:38:50 UTC
Well this is a big problem with lots of implications:

To make it simple we recently decided on the ressource/presets guidelines to have filenames = description.
So one can easily find the corresponding file matching the description string (if any).
There are still a few files that have different filename/description, these should be cleaned up to follow this guideline.

In this regard, it conflicts a bit with the idea of translatable string, as if those get translated they won't match the file names anymore... 

We also decided to avoid too long file names.

On the pattern files, most of them just show file names directly (all the png files, and most of the pat files)

On the brushes files, most of them have already been edited to have description string = filename. A few still need this, and a few may need a better descriptive filename too..

Problem is if we rename some of those files, it also breaks all presets using it, for default pack (those I can edit) but also for user presets..
That's why mass ressource renaming should be avoided (which explains why some still have not optimal names..)

Also I wonder if having those strings translated may have a bad side effect:
Do presets use filenames only or description to link brushes/patterns?
Same question for tagging?

Then about the term "canvas" used in some patterns, well I don't see a better word for this is exactly some canvas pattern, meant to fake material canvas one paints on in real life.. changing it to jeans or whatever would miss totally this meaning.
Comment 3 Sven Langkamp 2013-12-04 13:26:28 UTC
The only change I see would be to change the strings to something like:

i18nc("./data/brushes/U_Circle_shape_4.gbr","U Circle shape 4");
i18nc("./data/brushes/U_Circle_shape_5.gbr","U Circle shape 5");

We can't change the filename themself as they might be referenced in some presets already.
Comment 4 Sven Langkamp 2014-04-02 17:27:16 UTC
Git commit 287efe42475bb955d05e343ca8f867ad84d08da4 by Sven Langkamp.
Committed on 02/04/2014 at 17:25.
Pushed by langkamp into branch 'master'.

added file hint for resource translations

M  +7    -7    krita/extracti18n.pl

http://commits.kde.org/calligra/287efe42475bb955d05e343ca8f867ad84d08da4