groups with zero contacts are displayed
groups with zero contacts are displayed see the attach
Created attachment 77504 [details]
This is due to code being commented out in ContactsFilterModel::filterAcceptsGroup
re-enabling it, however, causes no groups to be shown.
There's a race condition/the counting happens in a wrong place.
I showed you in Brussels on a paper if you remember. I'll try to put it back together and post here.
Ok, the case I had in Brussels was with my KPeople model, the situation with our models is a bit different. Here are my findings:
- the groups are correctly counted and properly filtered (filterAcceptsRow/filterAcceptsGroup returns correct values)
- whenever we return false in filterAcceptsGroup, it all breaks
- if we switch filtering of offline contacts off/on, it works properly (the filter is invalidated)
As of now, I'm unsure where the problem of showing no groups at all is.
Git commit ee230048214fd33a4064fd991b5e3f3956182577 by David Edmundson.
Committed on 22/07/2013 at 17:29.
Pushed by davidedmundson into branch 'kde-telepathy-0.6'.
Restore hiding empty groups
M +6 -4 KTp/Models/contacts-filter-model.cpp