Bug 315405 - Dolphin no longer shows disk usage when hovering places item
Summary: Dolphin no longer shows disk usage when hovering places item
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: panels: places (show other bugs)
Version: 2.2
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: regression
: 317807 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-02-18 18:57 UTC by Kai Uwe Broulik
Modified: 2020-11-05 02:48 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 20.12


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Uwe Broulik 2013-02-18 18:57:26 UTC
Till the rewrite of the Places panel in 4.9 when you hovered a device, a little bar indicating device usage, appeared. This is no longer the case.

Reproducible: Always

Steps to Reproduce:
1. Plug in USB stick or external HDD
2. Hover its places item
3.
Actual Results:  
Item turns blue ;)

Expected Results:  
A bar indicating disk usage appears
Comment 1 Frank Reininghaus 2013-02-18 23:20:40 UTC
Thanks for the report, but the removal of this "free space bar" was done on purpose, see, e.g.,

http://forum.kde.org/viewtopic.php?f=223&t=108472

I'm fine with leaving this open as a wish though.
Comment 2 Frank Reininghaus 2013-04-04 07:43:40 UTC
*** Bug 317807 has been marked as a duplicate of this bug. ***
Comment 3 Frank Reininghaus 2013-04-04 07:49:27 UTC
Since people have repeatedly asked to re-add that feature, here are a few remarks:

1. The way KFilePlacesView, which was used in Dolphin 1.x and is still used in the file dialog, retrieves the free space in the paint() method is, at least IMHO, a big hack.

2. When the free space was still shown while hovering devices, we got quite a few bug reports about this, for example about optical drives starting to spin while their icon was hovered, or about Dolphin freezing when hovering a drive that was not accessible for some reason.

This is why I am strongly against re-implementing this feature.
Comment 4 Martín Cigorraga 2013-04-04 13:15:06 UTC
Then it makes totally sense to hold this feature back.

Thank you very much for taking the time to explain us this.
Comment 5 Richard Llom 2013-06-06 12:02:35 UTC
(In reply to comment #4)
> Then it makes totally sense to hold this feature back.
Although I agree here (with holding it back), but are there actual thoughts how to circumvent these problems with another implementation? And ofc without too much code (I guess it wouldn't be implemented then anyway).

Another problem of the current state is that this feature available in the file-open dialog, but not in dolphin, so this is kind of inconsistent.
Comment 6 Frank Reininghaus 2013-06-06 12:12:06 UTC
(In reply to comment #5)
> Although I agree here (with holding it back), but are there actual thoughts
> how to circumvent these problems with another implementation?

You can just click the device in the panel and either see the free space in the status bar (provided you have enabled that - if not, just right click the status bar and do that) or with the properties dialog.

> Another problem of the current state is that this feature available in the
> file-open dialog, but not in dolphin, so this is kind of inconsistent.

Yes, these inconsistencies are one of the reasons why I now consider the decision to write a custom Places Panel for Dolphin (which has not been taken by myself) unfortunate, even when considering the additional new features.

I hope that there will be a new shared "Places" implementation, maybe QML-based, in the KDE frameworks era.
Comment 7 Nate Graham 2019-05-20 21:36:33 UTC
Here's a patch: https://phabricator.kde.org/D21312
Comment 8 Bug Janitor Service 2020-07-01 14:30:59 UTC
A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/31
Comment 9 Nate Graham 2020-11-05 02:48:47 UTC
Implemented by Chris Holland with https://invent.kde.org/system/dolphin/-/commit/ac6de72048fb50bca1823b8001fb012158050c25 in Dolphin 20.12!