Bug 315321 - kde4_add_app_icon search breaks when more than one set of icon is present
Summary: kde4_add_app_icon search breaks when more than one set of icon is present
Status: RESOLVED WORKSFORME
Alias: None
Product: kdelibs
Classification: Unmaintained
Component: general (show other bugs)
Version: 4.10.0
Platform: MacPorts macOS
: NOR normal
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-17 14:00 UTC by Nicolas Pavillon
Modified: 2022-11-16 05:16 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Pavillon 2013-02-17 14:00:05 UTC
When more than one set of icon is present in a folder (or subfolders), the function kde4_add_app_icon breaks as it tries to add both sets of icons, crashing compilation.

This happens for example with pairs, which has two sets of icons, in its icons/ folder, or with kmines, which as a data/icons-old folder within the icons.

Reproducible: Always

Steps to Reproduce:
1. Put two sets of icons in a folder
2. Use function kde4_add_app_icon function for cmake
3. Launch compilation
Actual Results:  
Compilation breaks at configure stage with errors of the type:

CMake Error: Attempt to add a custom rule to output "/opt/local/var/macports/build/_Users_nicos_ports_kde_pairs/pairs/work/build/game/pairs_SRCS.iconset/icon_16x16.png.rule" which already has a custom rule.

Expected Results:  
Configure should complete.

Employing separate folders for each icon set (and without using subfolders) makes it possible to build several applications with their own icons. Only the location in the folder architecture causes problems.

I am not fully sure if this behaviour of the function is intended. If that is the case, it means that several applications employing it do not use it correctly.
Comment 1 Justin Zobel 2022-10-17 00:40:50 UTC
Thank you for reporting this bug in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "CONFIRMED" when replying. Thank you!
Comment 2 Bug Janitor Service 2022-11-01 05:04:42 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 3 Bug Janitor Service 2022-11-16 05:16:08 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!