Bug 315282 - "What's This" shows <ul> <li> <em> tags
Summary: "What's This" shows <ul> <li> <em> tags
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: general (show other bugs)
Version: 5.1.95
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: KWin default assignee
URL: https://git.reviewboard.kde.org/r/122...
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-16 18:29 UTC by G360
Modified: 2015-01-14 07:25 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/kwin/0577dee236e2a8735cf25db3d858cb6c12c1fd14
Version Fixed In: 5.3.0
Sentry Crash Report:
mgraesslin: ReviewRequest+

Attachments
Screenshot showing the problem. (134.86 KB, image/png)
2013-02-16 19:15 UTC, G360 		Details
A small patch that simply gets rid of the <ul>s and <li>s and rename's the title to "New Window Placement" (1.95 KB, patch)
2013-03-17 13:51 UTC, tang0th 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description G360 2013-02-16 18:29:11 UTC 
When using "What's This" in "Window Behavior" -> "Window Behavior" -> "Advanced" -> "Placement" combo box, <ul> <li> <em> tags are shown.

Reproducible: Always
Comment 1 G360 2013-02-16 19:15:59 UTC 
Created attachment 77369 [details]
Screenshot showing the problem.
Comment 2 Thomas Lübking 2013-02-16 19:31:44 UTC 
Proposal:
remove "what's this" and name the group "Where to place new windows" or so. At least the english WT is ridiculous.
Comment 3 tang0th 2013-03-17 13:51:34 UTC 
Created attachment 78131 [details]
A small patch that simply gets rid of the <ul>s and <li>s and rename's the title to "New Window Placement"

I decided to quickly create a patch for this bug, but this is the first time I've done this, so I haven't gone through any official channels and its untested (but the change is minor). Sorry if I've done something wrong or if I've accidentally stepped on someone's toes. I hope the patch works/helps.
Comment 4 Martin Flöser 2015-01-14 07:25:49 UTC 
Git commit 0577dee236e2a8735cf25db3d858cb6c12c1fd14 by Martin Gräßlin.
Committed on 13/01/2015 at 11:47.
Pushed by graesslin into branch 'master'.

[kcmkwin/options] Ensure rich text is recognized as rich text

The heuristic checks whether there is something which looks like a
tag before the first line break. So let's use a <br> instead of a \n
for the first line break.
FIXED-IN: 5.3.0
REVIEW: 122032

M  +1    -2    kcmkwin/kwinoptions/advanced.ui

http://commits.kde.org/kwin/0577dee236e2a8735cf25db3d858cb6c12c1fd14