Bug 315163 - Textfields in Firefox have grey background color instead of white color which is set in KDE
Summary: Textfields in Firefox have grey background color instead of white color which...
Status: RESOLVED NOT A BUG
Alias: None
Product: Oxygen
Classification: Plasma
Component: gtk2-engine (show other bugs)
Version: 4.10
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-14 20:36 UTC by denk
Modified: 2013-03-02 22:13 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
A try to detect aurora as firefox (362 bytes, patch)
2013-03-02 21:49 UTC, Ruslan Kabatsayev 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description denk 2013-02-14 20:36:47 UTC 
In KDE systemsettings I set the standard Oxygen color theme. In every KDE program textboxes have a white background as it should be. Only Firefox doesn't respect the color settings and every textbox has a grey background there.

Reproducible: Always

Actual Results:  
Textboxes have grey background color instead of white one.

Expected Results:  
Textboxes have white background color.

I've also activated the setting "Farben auf Nicht-KDE-4-Programme anwenden" (that's the german localization, in english it should be something like "Apply colors on Non-KDE-4-programs").
Comment 1 Ruslan Kabatsayev 2013-02-14 20:42:25 UTC 
This is a dup of bug 314545. Please use latest bug-fix release.

*** This bug has been marked as a duplicate of bug 314545 ***
Comment 2 Ruslan Kabatsayev 2013-02-21 16:10:36 UTC 
OK, I see from your screenshot that this is a different bug.
What is your firefox version? Has this worked with earlier oxygen-gtk? If yes, please use git-bisect to find which commit introduced this bug.
Comment 3 denk 2013-03-02 21:06:13 UTC 
I'm sorry, oxygen-gtk is not the cause for my problem. I tried another build of Firefox and it works now. Do you know of any build options for Firefox which could cause the grey color of textfields?
Comment 4 Ruslan Kabatsayev 2013-03-02 21:09:17 UTC 
(In reply to comment #3)
> I'm sorry, oxygen-gtk is not the cause for my problem. I tried another build
> of Firefox and it works now. Do you know of any build options for Firefox
> which could cause the grey color of textfields?

Don't know precisely, but your previous build of firefox might have been detected not as firefox, (which we get from g_get_application_name() and some other ways), so the workarounds for its bad GTK usage weren't applied.
Comment 5 denk 2013-03-02 21:18:38 UTC 
Thanks for that hint! That could indeed be the cause for that. Before I used a patched build of Aurora. The patch renames MOZ_APP_BASENAME from Firefox to Aurora. Does this variable count for deciding if the workarounds should be applied or not?
Comment 6 Ruslan Kabatsayev 2013-03-02 21:20:11 UTC 
Most likely then firefox set its gtk name to aurora or something like that, which made our logic fail at detecting firefox.
Comment 7 denk 2013-03-02 21:46:57 UTC 
OK. Would it then be possible to add aurora to your logic?
Comment 8 Ruslan Kabatsayev 2013-03-02 21:49:57 UTC 
Created attachment 77693 [details]
A try to detect aurora as firefox

Please test if this patch makes aurora look correctly.
Comment 9 denk 2013-03-02 22:10:04 UTC 
It works. Thanks for the patch and fixing my problem!
Comment 10 Ruslan Kabatsayev 2013-03-02 22:13:13 UTC 
Git commit 8917b9f3961442e6569930457499540bdbb13699 by Ruslan Kabatsayev.
Committed on 02/03/2013 at 23:12.
Pushed by kabatsayev into branch '1.3'.

Detect aurora as a XUL app

M  +1    -0    src/oxygenapplicationname.cpp

http://commits.kde.org/oxygen-gtk/8917b9f3961442e6569930457499540bdbb13699