Bug 314834 - Undoing pawn promotion doesn't restore pawn icon
Summary: Undoing pawn promotion doesn't restore pawn icon
Status: RESOLVED FIXED
Alias: None
Product: knights
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Miha Čančula
URL:
Keywords:
: 339704 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-02-10 16:22 UTC by Massimiliano
Modified: 2016-04-03 08:17 UTC (History)
3 users (show)

See Also:
Latest Commit: http://commits.kde.org/knights/403750a3a0105b2e8d97b52f18399565d85d3941
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Patch for bug 314834 (444 bytes, patch)
2014-03-17 23:46 UTC, Dave Kaye 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Massimiliano 2013-02-10 16:22:35 UTC 
I promoted a pawn and then won the game, saved and closed.
Later, I reloaded the game and undid all the moves, but the pawn did not undo the icon change from queen to pawn.

Reproducible: Didn't try

Steps to Reproduce:
1. Promote
2. Undo move
Actual Results:  
Icon doesn't revert

Expected Results:  
Icon reverts
Comment 1 Dave Kaye 2014-03-17 23:46:41 UTC 
Created attachment 85622 [details]
Patch for bug 314834

Will work on both versions 2.5.0 and 2.4.2
Comment 2 Dave Kaye 2014-03-17 23:48:24 UTC 
See bug 332194 for additional pawn promotion bug patches and a test case game.
Comment 3 Alexander Semke 2016-04-03 08:16:05 UTC 
Git commit 403750a3a0105b2e8d97b52f18399565d85d3941 by Alexander Semke.
Committed on 03/04/2016 at 08:15.
Pushed by asemke into branch 'master'.

When undoing pawn promotion, set the piese back to pawn.

M  +4    -0    src/core/move.cpp

http://commits.kde.org/knights/403750a3a0105b2e8d97b52f18399565d85d3941
Comment 4 Alexander Semke 2016-04-03 08:17:38 UTC 
*** Bug 339704 has been marked as a duplicate of this bug. ***