Bug 314520 - Regression: Text in notification pop-up is not in line with its icon
Summary: Regression: Text in notification pop-up is not in line with its icon
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: notifications (show other bugs)
Version: 4.10.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-06 14:27 UTC by Nikola Schnelle
Modified: 2013-03-27 23:19 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.10.1


Attachments
Screenshot (36.85 KB, image/png)
2013-02-07 01:55 UTC, Hrvoje Senjan
Details
Screenshot (72.84 KB, image/png)
2013-03-27 23:19 UTC, Hrvoje Senjan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikola Schnelle 2013-02-06 14:27:50 UTC
Spacing in notification pop-up is wrong/bad in 4.10.0. It was ok in rc3.

Screenshot: http://www.dodaj.rs/f/2P/9W/VBg08YJ/snapshot1.png

Reproducible: Always
Comment 1 Nikola Schnelle 2013-02-06 16:55:07 UTC
Another screenshot: http://www.dodaj.rs/f/3Q/Ii/1OPmaqqp/snapshot4.png

Text in notification isn't in line with icon. It was ok in rc3.
Comment 2 Daniel Kreuter 2013-02-06 19:04:01 UTC
Same issue on Netrunner OS after upgrading to KDE 4.10.
Only appears when the popup is shown the first time. Clicking on the notification icon to reopen the popup and the icon is aligned correct.
Comment 3 Nikola Schnelle 2013-02-06 19:19:04 UTC
When notification pops up for the first time (wrongly aligned text) : http://www.dodaj.rs/f/1t/G8/2Oz5Nctp/snapshot6.png

When notification is reopened: http://www.dodaj.rs/f/8/Zz/k7WLuhN/snapshot7.png
Comment 4 Hrvoje Senjan 2013-02-07 01:55:51 UTC
Created attachment 76960 [details]
Screenshot

Looks fine here when there's no title.
Issue is introduced with commit a77609c from kde-workspace
Comment 5 Nikola Schnelle 2013-02-07 07:50:40 UTC
(In reply to comment #4)
> Created attachment 76960 [details]
> Screenshot
> 
> Looks fine here when there's no title.
> Issue is introduced with commit a77609c from kde-workspace

I can confirm this.
Comment 6 Marco Martin 2013-02-07 16:59:28 UTC
Git commit 2282c02cf37f4e66d3815a6224e81c2a18165f9e by Marco Martin.
Committed on 07/02/2013 at 17:56.
Pushed by mart into branch 'KDE/4.10'.

always center text to icon if possible

stop to vertically center the text on the icon only when it's too tall
FIXED-IN:4.10.1

M  +5    -3    plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml

http://commits.kde.org/kde-workspace/2282c02cf37f4e66d3815a6224e81c2a18165f9e
Comment 7 Nikola Schnelle 2013-03-06 22:02:51 UTC
This is not fixed in 4.10.1 :
http://www.dodaj.rs/f/s/LK/1Sibavfv/snapshot1.png
http://www.dodaj.rs/f/D/fi/wNtafjU/snapshot10.png
Comment 8 Hrvoje Senjan 2013-03-27 23:19:38 UTC
Created attachment 78446 [details]
Screenshot

Seems it is aligned fine with latest master. TBH, didn't noticed it is not working correctly after commit 2282c0 (but didn't look that hard :-) )