Bug 314410 - Italic rendition not supported
Summary: Italic rendition not supported
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: emulation (show other bugs)
Version: 2.10.999
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-04 11:15 UTC by Job Noorman
Modified: 2013-02-14 19:58 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 4.11
Sentry Crash Report:


Attachments
Patch that adds support for italic rendition (2.72 KB, patch)
2013-02-04 11:16 UTC, Job Noorman
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Job Noorman 2013-02-04 11:15:10 UTC
Setting or unsetting italic rendition (SGR parameters 3 and 23 respectively) are not supported by Konsole.

I will attach a simple patch that fixes this.

Reproducible: Always
Comment 1 Job Noorman 2013-02-04 11:16:08 UTC
Created attachment 76898 [details]
Patch that adds support for italic rendition
Comment 2 Job Noorman 2013-02-04 11:41:43 UTC
Just a thought in relation to https://bugs.kde.org/show_bug.cgi?id=145977.

Since xterm does not support italic rendition, it might be a good idea to add a terminfo entry for Konsole. Maybe it could be installed along with Konsole instead of adding it to terminfo.

Of course, this thought is irrelevant if my patch would not be accepted :-)
Comment 3 Kurt Hindenburg 2013-02-14 19:58:22 UTC
Git commit 68a98ed77063e622985d422b625d7dc5895f10c3 by Kurt Hindenburg.
Committed on 14/02/2013 at 20:53.
Pushed by hindenburg into branch 'master'.

Add support for ANSI SGR escape code 3 (italics)

Adds support for escape sequences \e[3m and \e[23m (to turn italics on
and off respectively).
http://en.wikipedia.org/wiki/ANSI_escape_code#CSI_codes

Patch by Jem Orgun jeorgun@gmail.com
REVIEW: 108844
FIXED-IN: 4.11

M  +3    -2    src/Character.h
M  +4    -1    src/TerminalDisplay.cpp
M  +2    -0    src/Vt102Emulation.cpp

http://commits.kde.org/konsole/68a98ed77063e622985d422b625d7dc5895f10c3