Bug 314258 - File sort order is not copied for duplicated tab
Summary: File sort order is not copied for duplicated tab
Status: RESOLVED FIXED
Alias: None
Product: krusader
Classification: Applications
Component: general (show other bugs)
Version: 2.4.0-beta1 "Migration"
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krusader Bugs Distribution List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-01 17:04 UTC by kirill
Modified: 2018-05-06 00:15 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Proposed patch (1.15 KB, patch)
2017-02-01 12:29 UTC, Wladimir Palant
Details
Proposed patch (1.19 KB, patch)
2017-02-02 11:52 UTC, Wladimir Palant
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kirill 2013-02-01 17:04:24 UTC
Steps to reproduce:
1. Click "Ext" column on active tab to order files by extensions.
2. Duplicate active tab

Actual result:
files ordered by Name in duplicated tab not by extension.
Comment 1 Wladimir Palant 2017-02-01 10:28:22 UTC
This is still an issue with the current Git master (2.5.1-beta, revision 5056272).
Comment 2 Wladimir Palant 2017-02-01 12:29:51 UTC
Created attachment 103748 [details]
Proposed patch

Attached working patch, this will make sure to duplicate tab settings when a tab is duplicated. I'm not really familiar with the code but this seems to be the right way to do it.
Comment 3 Wladimir Palant 2017-02-02 11:52:05 UTC
Created attachment 103772 [details]
Proposed patch

Previous patch didn't remove the temporary configuration group which left some trash in the config file. I fixed this now.
Comment 4 Wladimir Palant 2017-02-02 20:59:27 UTC
Now that I figured out how to register for Phabricator I created a proper review: https://phabricator.kde.org/D4418
Comment 5 Alex Bikadorov 2017-02-13 20:42:29 UTC
Git commit b56a40421e24e101932f4dd2e279e51710cdaaad by Alexander Bikadorov, on behalf of Wladimir Palant.
Committed on 13/02/2017 at 20:35.
Pushed by abikadorov into branch 'master'.

#314258 - Duplicate tab settings when duplicating tabs

Summary: Whenever a new tab is created with this change we'll try to copy configuration from an existing tab. I'm not really familiar with the code but this seems to be the right way to do it.

Test Plan:
When duplicating tabs, various tab settings should be duplicated as well:

* Sort column and order
* Zoom factor
* View type (brief vs. detailed)
* View filter (all files vs. custom)
* "Show Previews" setting

There are also some `ListPanel` properties being duplicated but I don't know how these are set.

Tab duplication should not create unnecessary sections in the config file.

Reviewers: #krusader, abika, martinkostolny, asensi

Reviewed By: #krusader, abika, martinkostolny, asensi

Subscribers: asensi, martinkostolny, abika, #krusader

Tags: #krusader

Differential Revision: https://phabricator.kde.org/D4418

M  +14   -1    krusader/panelmanager.cpp

https://commits.kde.org/krusader/b56a40421e24e101932f4dd2e279e51710cdaaad