Bug 314251 - Keybindings for notes don't work after closing the search bar
Summary: Keybindings for notes don't work after closing the search bar
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 0.19.60
Platform: Fedora RPMs Linux
: NOR minor
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2013-02-01 14:27 UTC by Francesco Frassinelli
Modified: 2014-09-30 21:15 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.14.2
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Francesco Frassinelli 2013-02-01 14:27:10 UTC
Keybindings for notes don't work after closing the search bar until you refocus the note toolbar.

Reproducible: Always

Steps to Reproduce:
1. Press F6
2. Press 1, 2, 3 (keybindings work)
3. Press CTRL+F
4. Close the search bar
5. Press 1, 2, 3 (keybindings don't work anymore)
6. Press F6 two times
7. Press 1, 2, 3 (keybindings don't work anymore)
Actual Results:  
Keybindings don't work after using the search bar.

Expected Results:  
They should work after closing the search bar

In order to make them works again you have to press on it with the cursor.

Version: 0.15.98
Comment 1 Albert Astals Cid 2013-02-05 22:09:01 UTC
Note, you have to close it pressing the [x], doing CTRL+F doesn't reproduce the problem

That's because closing the bar gives the focus to the page number edit field, so pressing 1 is actually writing an 1 in there, just press tab a few times (or even better shift+tab once) to get the focus back to the listview.

I agree that it makes more sense that the focus goes back to the listview instead that at the pagenumber edit.
Comment 2 Albert Astals Cid 2014-09-30 21:15:25 UTC
Git commit f62153231be89150b8a8ddea3da2f0828855d22b by Albert Astals Cid, on behalf of Nidhi Jain.
Committed on 30/09/2014 at 21:14.
Pushed by aacid into branch 'KDE/4.14'.

Move focus to view when closing the find bar with the [x] button
REVIEW: 120307
FIXED-IN: 4.14.2

M  +1    -0    part.cpp
M  +1    -0    ui/findbar.cpp
M  +1    -0    ui/findbar.h

http://commits.kde.org/okular/f62153231be89150b8a8ddea3da2f0828855d22b