Bug 313223 - Important mails are not highlighted anymore
Summary: Important mails are not highlighted anymore
Status: RESOLVED FIXED
Alias: None
Product: kmail2
Classification: Applications
Component: message list (show other bugs)
Version: Git (master)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-14 09:41 UTC by András Manţia
Modified: 2013-04-21 13:08 UTC (History)
6 users (show)

See Also:
Latest Commit: http://commits.kde.org/kdepim/2c4a1e35a964010aa091454169318644aa7046bf
Version Fixed In: 4.10.3
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description András Manţia 2013-01-14 09:41:32 UTC 
Mails marked as important used to be highlighted in a different color, IIRC it was either green or red. Now they aren't highlighted. The Color page has "Use custom colors" disabled and that shows that indeed Important (and others as well) are configured to black by default. This is a regression, the old style defaults should be kept imo.
Comment 1 András Manţia 2013-01-14 09:45:42 UTC 
Note: actually they are marked as green when I mark a message important, but the green color disappears when I click on the message for *certain* messages (not all of them).
Comment 2 Laurent Montel 2013-01-14 10:39:00 UTC 
4.10 ?
master ?
Look at your "tag" tab in settings and look at color for "important" tag
Comment 3 András Manţia 2013-01-14 10:45:49 UTC 
Master. Tag tab? I have Settings->Configure KMail->Appearance->Message Tags, but it is empty.Settings->Configure KMail->Appearance->Colors have the default colors ("Use custom colors" is not checked).
Comment 4 Laurent Montel 2013-01-14 11:01:10 UTC 
ok message tags empty.

will look at why important doesn't use default color.
Comment 5 Laurent Montel 2013-01-18 07:06:38 UTC 
Tab is empty  => not tag (=> you removed all tags)

or there is a message which told you that nepomuk doesn't run ?

Because I disable nepomuk and it works fine here.
Comment 6 Laurent Montel 2013-01-21 08:06:38 UTC 
Need more infos.
Comment 7 András Manţia 2013-01-21 08:40:01 UTC 
I didn't remove any tags, I never used them. I only used the standard things, like mark as read and mark as importn. My nepomuk runs fine.
As I said it happens only for certain messages. I will give you some screenshots.
Comment 8 Antonio Rojas 2013-01-21 08:53:56 UTC 
Same issue here in 4.9.98, with an IMAP account. The important mails are highlighted when the folder loads, but they lose the color as soon as the mouse pointer moves over the message list
Comment 9 Christoph Feck 2013-02-04 22:15:45 UTC 
Are there exacts steps to reproduce this issue known?
Comment 10 András Manţia 2013-02-05 07:16:30 UTC 
Yes, sorry that the bug was not updated, we discussed this with Laurent. The problem is that Nepomuk tag coloring overwrites the default coloring (there is also an important tag for Nepomuk), causing the green coloring to disappear.
Comment 11 Lamarque V. Souza 2013-04-20 12:37:59 UTC 
Patch submitted to fix this bug https://git.reviewboard.kde.org/r/110098/
Comment 12 Franz Trischberger 2013-04-20 13:57:45 UTC 
https://bugs.kde.org/show_bug.cgi?id=301273
It was "somehow" related to attica for me. As I don't use kmail anymore (and built my system with semantic-desktop disabled) I am not able to test your patch :(
Comment 13 Lamarque V. Souza 2013-04-21 12:58:24 UTC 
Git commit 2c4a1e35a964010aa091454169318644aa7046bf by Lamarque V. Souza.
Committed on 21/04/2013 at 14:54.
Pushed by lvsouza into branch 'KDE/4.10'.

Fix importand and todo highlighting in kmail2's message list.

REVIEW: 110098

M  +1    -1    messagelist/core/messageitem.cpp

http://commits.kde.org/kdepim/2c4a1e35a964010aa091454169318644aa7046bf