Bug 311859 - Show typing icon in tabbar and window title
Summary: Show typing icon in tabbar and window title
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Unmaintained
Component: text-ui (show other bugs)
Version: 0.5.1
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: 0.6-next
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-17 22:43 UTC by Detlev Casanova
Modified: 2013-03-05 20:42 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 0.6.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Detlev Casanova 2012-12-17 22:43:09 UTC
When using one window for multiple chats in tabs, the "Typing..." iformation isn't shown for each person. Instead, it shows in the window title when someone is typing.

The problem is that it is impossible to know who is typing. It would be great to integrate this in the window, not just in the window title.

Reproducible: Always
Comment 1 David Edmundson 2012-12-17 22:56:26 UTC
This isn't trivial to do. 

The main window part is shared themes from  http://adiumxtras.com/index.php?a=search&cat_id=5. Obviously we don't have access to change these, and if we did we'd break the entire theme support.

If you have any ideas, I'll happily listen. Otherwise there's not a lot we can do.
Comment 2 Martin Klapetek 2012-12-18 07:03:18 UTC
Fwiw, the original design was to have the "Typing..." in the title only if the current active tab has a typing user. This was later changed/broken and was showing "Typing..." if anyone in any of the tabs of the current window was typing. 

Also, the tab text changes color when that contact is typing, so it sort of is already integrated in the window. We could also change the tab/window icon (and I still want to use the dockmanager api to indicate stuff).
Comment 3 David Edmundson 2012-12-18 08:10:17 UTC
So for the original poster, Martin is right the tab text goes green, though clearly this isn't easily discovereable as I've seen two people ask now.

We could show the typing icon instead of the presence icon as the tab icon. 

if unread message -> message icon
else if typing -> typing icon
else  -> presence icon
Comment 4 Lasath Fernando 2012-12-21 11:06:44 UTC
Also, instead of just saying "Typing..." in the title, we could say 
"David is typing..." or 
"David, Martin and Detlev are typing...".

It should be feasible since we have access to the Tp::TextChannel and Tp::Contact (IIRC).
Comment 5 Martin Klapetek 2012-12-21 11:10:29 UTC
The main case for prepending it was because of the taskbar, where you'd see the change in window title; this wouldn't work if the task item is wide enough to fit just the name - appending the string would not be seen there. 

However if we can change the window icon, this problem no longer exists (and it's better for things like icon tasks anyway).
Comment 6 Martin Klapetek 2013-01-17 10:11:08 UTC
Ok I'm turning this task into changing the icons both in the tabbar and the window title (which in turn will change it in taskbar too). The text will remain unchanged, but I hope to fix the problem in comment #2 as well.
Comment 7 Daniel Vrátil 2013-01-20 17:00:05 UTC
Git commit b1d9d1df41e8993a79550366e7b5ef4c59942406 by Dan Vrátil.
Committed on 20/01/2013 at 17:59.
Pushed by dvratil into branch 'master'.

Change tab and window icon when someone is typing or there is unread message

Tabs will have 'unread-message' icon when there is an unread message.
When there are no unread messages, but other side is typing, it shows
a 'typing' icon. Otherwise contact's presence icon is used.

The window will have 'unread-message' icon when there is an unread message
in any tab. Otherwise will show 'typing' if user in current tab is typing.
Otherwise it shows current tab presence icon.

REVIEW: 108500
FIXED-IN: 0.6

M  +41   -1    app/chat-window.cpp
M  +3    -0    app/chat-window.h

http://commits.kde.org/telepathy-text-ui/b1d9d1df41e8993a79550366e7b5ef4c59942406