Bug 311548 - Potential infinite loop
Summary: Potential infinite loop
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Unmaintained
Component: kded-module (show other bugs)
Version: 0.5.1
Platform: unspecified Linux
: NOR normal
Target Milestone: Future
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-12 00:53 UTC by David Edmundson
Modified: 2012-12-12 00:56 UTC (History)
0 users

See Also:
Latest Commit: http://commits.kde.org/telepathy-kded-module/3277a4ada099b17a1e6d477f52181436d0d4410b
Version Fixed In: 0.5.2
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description David Edmundson 2012-12-12 00:53:47 UTC 
The kded module has a while loop in ContactRequestHandler::onContactRequestDenied which reads

while (i != list.constEnd()) {
  if (valid) {
     it++
  }
}

The it++ should obviously be outside the if.
Comment 1 David Edmundson 2012-12-12 00:56:23 UTC 
Git commit 3277a4ada099b17a1e6d477f52181436d0d4410b by David Edmundson.
Committed on 12/12/2012 at 01:54.
Pushed by davidedmundson into branch 'kde-telepathy-0.5'.

Fix potential infinite loop denying a contact

M  +1    -1    contact-request-handler.cpp

http://commits.kde.org/telepathy-kded-module/3277a4ada099b17a1e6d477f52181436d0d4410b