Bug 311329 - JJ: Better user feedback (error messages) in Amarok when transcoding from CD is not working due to lame not being installed
Summary: JJ: Better user feedback (error messages) in Amarok when transcoding from CD ...
Status: REOPENED
Alias: None
Product: amarok
Classification: Applications
Component: Collections/CD (show other bugs)
Version: 2.6.0
Platform: Ubuntu Linux
: LO task
Target Milestone: 2.8
Assignee: Amarok Developers
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2012-12-08 10:00 UTC by Philippe Bernery
Modified: 2014-08-11 20:36 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Bernery 2012-12-08 10:00:02 UTC
Hi,

I have an almost fresh install of Kubuntu 12.10.
I inserted an Audio CD I wanted to transcode into MP3. I right-clicked on the album of the audio cd in Amarok, clicked 'Copy to collection'. I then selected MP3 as the codec and configured the file name format.
After confirming the configuration, Amarok started to read my audio cd (I heard my cd player working) but stopped the task 1 sec after.

I finally found that I did not have lame installed. After installing it, it works well.

I think Amarok misses an information dialog to explain the user that lame must be installed before using the feature.

Reproducible: Always

Steps to Reproduce:
1. Use Amarok without lame installed
2. Insert an Audio CD
3. Right-click on the Audio CD, choose Copy to collection
4. Select MP3 as the codec, configure the track file name format
5. Launch extraction
Actual Results:  
It stops after 1 seconds without any feedback

Expected Results:  
It should at least show an error message explaining the user that Amarok needs lame to transcode to MP3.
Comment 1 Myriam Schweingruber 2012-12-08 14:31:17 UTC
This very much depends on the distribution, AFAIK the kubuntu-restricted-extras package you should install does include lame. It is up to the distribution to suggest the correct package to install.
Comment 2 Philippe Bernery 2012-12-08 14:41:21 UTC
I agree about the package suggestion.

However I believe that Amarok should display an error or information message when it fails at transcoding the Audio CD to MP3, or any other codecs, because the codec is not installed. Currently, it stops silently and there is no way to know why (or I did not find one).
Comment 3 Myriam Schweingruber 2012-12-08 14:49:41 UTC
You don't understand: this is a packaging error on the Kubuntu side, as it should suggest to install kubuntu-restricted-extras when you miss the codecs, if it didn't then they did something wrong.
Comment 4 Philippe Bernery 2012-12-08 16:19:27 UTC
Ok, I think I get your point. Thanks for pointing me out the kubuntu-restricted-extras package (it was not installed indeed).
Comment 5 Matěj Laitl 2012-12-08 20:12:42 UTC
I'm making this an junior job (about better error reporting) suitable for Amarok developer newcomers, students wanting to participate in GSoC. (to show they can solve bugs in code) etc...

Newcomers: feel free to contact me by e-mail or ping strohel on #amarok IRC, I can get you started.
Comment 6 Márcio Paiva 2013-03-16 05:16:46 UTC
@Matej, could you specify a little more what you errors deserve better reporting?
Comment 7 Myriam Schweingruber 2013-03-16 09:14:22 UTC
(In reply to comment #6)
> @Matej, could you specify a little more what you errors deserve better
> reporting?

Well, the error message should tell the reason why encoding is not working, e.g. what is missing
Comment 8 Abhinandan 2013-04-21 04:01:04 UTC
anyone working on this? if not, can i?
Comment 9 Matěj Laitl 2013-04-21 10:06:11 UTC
(In reply to comment #8)
> anyone working on this? if not, can i?

Sure, no need to ask for permission. Just try to solve this and submit a review request to http://reviewboard.kde.org/ once you think your patch is okay. It is also usual to put a link to the review request to the bug.
Comment 10 Abhinandan 2013-04-26 10:01:09 UTC
patch : https://git.reviewboard.kde.org/r/110150/
Comment 11 Myriam Schweingruber 2014-08-11 20:36:37 UTC
(In reply to Abhinandan from comment #10)
> patch : https://git.reviewboard.kde.org/r/110150/

What happened to this?