Bug 310819 - Some minor quirks in attachment properties dialog (read-only mode)
Summary: Some minor quirks in attachment properties dialog (read-only mode)
Status: RESOLVED FIXED
Alias: None
Product: kmail2
Classification: Applications
Component: commands and actions (show other bugs)
Version: 4.9.3
Platform: unspecified Linux
: NOR minor
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-28 13:06 UTC by Bernd Oliver Sünderhauf
Modified: 2012-12-19 07:32 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/kdepim/376d01d4d40a3f7fecddb1d16faff05b7809bb4b
Version Fixed In: 4.11

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Bernd Oliver Sünderhauf 2012-11-28 13:06:39 UTC 
When opening the attachment properties dialog from the message viewer (e.g. in read-only mode), it displays some minor quirks:
- "Encoding" is not displayed at all (making this issue a minor bug rather than a wishlist)
- "Type" and "Encoding" are rendered as select box, even though they're not changeable

Disabling the input widgets renders them hardly readable, even though that would be the most intuitive solution. So the properties should probably all be displayed as read-only textboxes, just like the "Name" already is.

Reproducible: Always
Comment 1 Laurent Montel 2012-11-28 13:22:37 UTC 
I improved it for 4.10.
Not all fixed but better in 4.10 :)
Will look at for other thing after.
Comment 2 Laurent Montel 2012-11-28 13:29:42 UTC 
"- "Encoding" is not displayed at all (making this issue a minor bug rather than a wishlist)" already fixed in 4.9.4
Comment 3 Bernd Oliver Sünderhauf 2012-11-28 14:15:04 UTC 
Obviously, 4.9.4 is going to bring lots of minor improvements... :)
Sorry that I can't work with it ATM, so I sometimes might report an already fixed issue.
Comment 4 Laurent Montel 2012-11-28 14:24:37 UTC 
"Sorry that I can't work with it ATM, so I sometimes might report an already fixed issue." no problem for me :)
Thanks for your help :)
Comment 5 Bernd Oliver Sünderhauf 2012-11-28 14:30:36 UTC 
(In reply to comment #4)
> Thanks for your help :)

And thank you for being such a responsive maintainer! There's still a lot of work to do in kmail, but one day, this will lead to kmail being a superior mail client.
Also, compared to some other KDE components, it really makes working in the kmail bug squad a pleasure! :)
Comment 6 Christoph Feck 2012-11-28 18:10:27 UTC 
Just make sure you do not report bugs faster than Laurent can fix them (if that's possible) :P

Thanks to both of you!
Comment 7 Laurent Montel 2012-12-01 13:53:01 UTC 
I looked at for 4.10, but I can't change combobox readonly in lineedit.
I will for 4.11 use 2 differents ui I think.
We will wait 4.11 :)
but it's better as 4.10 :)
Comment 8 Laurent Montel 2012-12-19 07:32:39 UTC 
Git commit 376d01d4d40a3f7fecddb1d16faff05b7809bb4b by Montel Laurent.
Committed on 19/12/2012 at 08:32.
Pushed by mlaurent into branch 'master'.

Fix Bug 310819 - Some minor quirks in attachment properties dialog

(read-only mode)
FIXED-IN: 4.11

M  +1    -0    messagecore/CMakeLists.txt
M  +101  -65   messagecore/attachmentpropertiesdialog.cpp
A  +177  -0    messagecore/attachmentpropertiesdialog_readonly.ui

http://commits.kde.org/kdepim/376d01d4d40a3f7fecddb1d16faff05b7809bb4b