Bug 310582 - Provide a means of clearing the collection browser filter history
Summary: Provide a means of clearing the collection browser filter history
Status: REPORTED
Alias: None
Product: amarok
Classification: Applications
Component: Collection Browser (show other bugs)
Version: 2.6.0
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: 2.7
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-23 23:34 UTC by robert marshall
Modified: 2014-07-27 18:20 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
patch implement clear filter history (5.13 KB, patch)
2012-11-26 03:38 UTC, Manuel Finessi
Details
image to new button (43.65 KB, image/png)
2012-11-26 03:43 UTC, Manuel Finessi
Details
Screenshot after a mistaken paste (24.53 KB, image/png)
2014-07-27 17:26 UTC, robert marshall
Details

Note You need to log in before you can comment on or make changes to this bug.
Description robert marshall 2012-11-23 23:34:47 UTC
If you filter the collection then that filter is retained in the history and you can reselect it without retyping/re-entering it (a good thing). It would also be good to have a means of clearing that history list (at least I can't see one in my version).
This feature is particularly useful if you think you're pasting (from mouse selection) a filter you've saved elsewhere - if however you were wrong and the mouse selection contains (say) 10 lines of other text then those 10 lines will appear in the history and it is a long scroll down past them to sensible data - the only way I can see of getting rid of the junk is to restart amarok.

Maybe privacy concerns might be another good reason for this feature if you don't want others to see that you've been browsing your collection for any items by (say) Ketelby! ;-)
Comment 1 Manuel Finessi 2012-11-26 03:38:29 UTC
Created attachment 75481 [details]
patch implement clear filter history

Hi, this patch implement (very simple) clear filter history.
Comment 2 Manuel Finessi 2012-11-26 03:43:46 UTC
Created attachment 75482 [details]
image to new button
Comment 3 Myriam Schweingruber 2012-11-26 08:09:34 UTC
Hi Manuel, thank you for your patch. Please submit it to reviewboard.kde.org ASAP
Comment 4 Alan Ezust 2014-07-27 15:40:27 UTC
This feature is not needed until it is possible to save filters persistently. At the moment, they are lost after each restart of Amarok.
Comment 5 robert marshall 2014-07-27 17:26:46 UTC
Created attachment 87985 [details]
Screenshot after a mistaken paste

I think it's needed precisely because you can't save the filters. As I say in the report, I keep often used filters in a text file which I paste into the filter pulldown (ie not bothering to use 'Edit Filter'), If I've mistakenly selected something else and it's a large quantity of data it makes that pull down hard to navigate.
Comment 6 Alan Ezust 2014-07-27 18:20:00 UTC
Yes, I agree, the patch is a workaround for the possibility of accidentally pasting garbage. But the submitter of the patch, Manuel, withdrew the patch for the reason I stated in my previous comment, so perhaps he needs to resubmit it.