Bug 310388 - Lancelot's main panel icon doesn't enlarge when the panel height increases
Summary: Lancelot's main panel icon doesn't enlarge when the panel height increases
Status: RESOLVED NOT A BUG
Alias: None
Product: plasma4
Classification: Unmaintained
Component: widget-lancelot (show other bugs)
Version: 4.9.3
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Ivan Čukić
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-19 23:18 UTC by Xavion
Modified: 2012-11-20 20:45 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Smaller panel height, larger Lancelot icon (28.52 KB, image/png)
2012-11-19 23:20 UTC, Xavion
Details
Larger panel height, smaller Lancelot icon (28.35 KB, image/png)
2012-11-19 23:21 UTC, Xavion
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xavion 2012-11-19 23:18:14 UTC
The main Kickoff icon enlarges with the panel, whereas that of Lancelot unfortunately doesn't.  I will soon attach two screenshots to demonstrate what I mean by this.

Reproducible: Always
Comment 1 Xavion 2012-11-19 23:20:41 UTC
Created attachment 75365 [details]
Smaller panel height, larger Lancelot icon
Comment 2 Xavion 2012-11-19 23:21:41 UTC
Created attachment 75366 [details]
Larger panel height, smaller Lancelot icon
Comment 3 Xavion 2012-11-19 23:26:12 UTC
The height of the panel in the second screenshot is larger, yet the size of the main Lancelot icon is actually smaller.  You should probably just copy the relevant panel icon expansion code across from Kickoff for consistency.
Comment 4 Christoph Feck 2012-11-19 23:57:18 UTC

*** This bug has been marked as a duplicate of bug 309767 ***
Comment 5 Christoph Feck 2012-11-19 23:59:28 UTC
Uh, wait, I read wrong. Reopening.
Comment 6 Ivan Čukić 2012-11-20 07:12:13 UTC
You can set the icon size at:
System Icons -> Application Appearance -> Icons -> Advanced -> Panel

Unlike the bug 309767, lancelot's behaviour has not changed.
Comment 7 Xavion 2012-11-20 09:32:16 UTC
I can confirm that setting the panel icon size manually does fix the problem.  However, why don't you want Lancelot's main icon to resize dynamically like Kickoff's does?
Comment 8 Ivan Čukić 2012-11-20 17:03:36 UTC
For me, it behaves exactly the same.

But, even if it doesn't - rationale behind it is two-fold:
- if we have this setting, we should obey it (most of the icons did so until bug 309767
- people that use vertical panels tend to make them wider to be able to show the window titles. Imageine a 200x200px lancelot icon in there
Comment 9 Xavion 2012-11-20 20:20:23 UTC
I hear what you're saying, but I still think Lancelot should behave like Kickoff in this way.  Most people won't realise that they need to set the panel icon size manually.

This is mainly because that setting is hidden away somewhere in the System Settings.  Perhaps there should be a link to it in the More Settings section of the Panel Toolbox.
Comment 10 Ivan Čukić 2012-11-20 20:45:21 UTC
It *is* a bit hidden config option, that I agree.

I don't, however, think that whenever other applets change the previously established behaviour, that Lancelot should follow. (especially when there are users that don't support the change in the first place).

For me, the current behaviour (that evolved from scale-and-take-as-much-space-as-possible through a few iterations here on bugs.kde.org) is the sane one. I'd need a really big reason for why it is bad in order to change it.

'It doesn't behave like kickoff' is not a reason I'd usually even consider - Lancelot was made not to be kickoff.