Bug 310280 - conjugation practice: verbs with all conjugations deleted still show up
Summary: conjugation practice: verbs with all conjugations deleted still show up
Status: RESOLVED WORKSFORME
Alias: None
Product: parley
Classification: Applications
Component: general (other bugs)
Version First Reported In: 0.9.4
Platform: NetBSD pkgsrc Linux
: NOR normal
Target Milestone: ---
Assignee: parley bug tracker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-18 12:45 UTC by kdebugs
Modified: 2023-01-19 05:17 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
entryfilter.cpp - add empty string as blocking reason (539 bytes, patch)
2012-11-18 12:45 UTC, kdebugs
Details
kvtml demonstrating the effect - verb d2 has a conjugations container (3.89 KB, application/x-kvtml)
2012-11-18 13:18 UTC, kdebugs
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kdebugs 2012-11-18 12:45:54 UTC
Created attachment 75333 [details]
entryfilter.cpp - add empty string as blocking reason

When you delete all conjugations from a verb, it retains an (empty)  "conjugation" structure. Since none of the standard blocking reasons (grade, last practice time) apply to the nonexistant members, the verb remains a candidate for practice, where it shows up as a question without any answer fields.

Upon File/Save, the .kvtml file shows a <conjugation>...</conjugation> container with just the tense list and nothing else. When opening a file with this structure, the useless <conjugation>...</conjugation> part is properly purged.

Probably this cleanup should already happen in the editor. My patch is way simpler, but it is just a workaround: add "empty string" as another blocking reason (src/practice/entryfilter.cpp, function EntryFilter::isBlocked() ).
Comment 1 kdebugs 2012-11-18 13:18:45 UTC
Created attachment 75335 [details]
kvtml demonstrating the effect - verb d2 has a conjugations container
Comment 2 Andrew Crouthamel 2018-11-09 00:53:41 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 3 Andrew Crouthamel 2018-11-18 03:30:57 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!
Comment 4 Justin Zobel 2022-12-20 22:51:38 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 5 Bug Janitor Service 2023-01-04 05:26:48 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 6 Bug Janitor Service 2023-01-19 05:17:05 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!