Bug 309816 - Searching for sleep/hibernate shows title "PowerDevil"
Summary: Searching for sleep/hibernate shows title "PowerDevil"
Status: RESOLVED FIXED
Alias: None
Product: Powerdevil
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Development Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-09 17:01 UTC by Martin Flöser
Modified: 2015-03-13 10:16 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Flöser 2012-11-09 17:01:40 UTC
When searching for the Suspend to RAM/Disk (sleep/hibernate) options instead of title "Power" title "PowerDevil" is shown. For other actions like "shutdown", "lock" the appropriate titles are shown.

Reproducible: Always

Steps to Reproduce:
1. Open Homerun
2. Search for sleep
Actual Results:  
Category title is "PowerDevil"

Expected Results:  
Category title is "Power"
Comment 1 Aurelien Gateau 2012-11-12 16:17:06 UTC
This is because the search results are provided by the Powerdevil runner. I 
think the "Powerdevil" term should not be exposed by the runner. What do you 
think?
Comment 2 Martin Flöser 2012-11-12 17:33:18 UTC
agreed, it's very tech speak and also not a good name "what has the devil to 
do in my computer?"
Comment 3 Aurelien Gateau 2012-11-13 13:29:39 UTC
OK, updating product/component then.
Comment 4 Alex Fiestas 2013-04-02 18:49:34 UTC
This seems to be fixed now on master at least, can you check please?
Comment 5 Martin Flöser 2013-04-03 06:10:18 UTC
(In reply to comment #4)
> This seems to be fixed now on master at least, can you check please?
do you have me a git commit I should be sure it's included because my current random build is still showing powerdevil.
Comment 6 Alex Fiestas 2013-04-03 09:04:31 UTC
http://wstaw.org/m/2013/04/03/plasma-windowedj13293.png

Using master from this morning, "sleep" produces the same results.

is it possible you have a dirty installation with .desktops from before ?

Can you attach a screenshot to see how the result look like?

@Aurelien Gateau  is there anyway of knowing which runner is outputing the element?
Comment 7 Martin Flöser 2013-04-03 09:23:31 UTC
@Alex: your screenshot is nicely highlighting the issue. Above sleep the category is called "PowerDevil" and not "Power"
Comment 8 Martin Flöser 2013-04-04 08:09:10 UTC
reopening as issue is still shown in screenshot.
Comment 9 Eike Hein 2013-07-29 09:26:39 UTC
This happens because Plasma::AbstractRunner falls back to objectName():

http://lxr.kde.org/source/kde/kdelibs/plasma/abstractrunner.cpp#294

And the PowerDevil runner sets an objectName "PowerDevil":

http://lxr.kde.org/source/kde/kde-workspace/plasma/generic/runners/powerdevil/PowerDevilRunner.cpp#43

Not sure why this fallback happens ... for some reason the KPluginInfo for the PowerDevil runner's .desktop file must be !isValid().
Comment 10 Alex Fiestas 2013-07-29 14:04:54 UTC
Ups, used CCMAIL instead of CCBUG xD...

This commit fixes the technical issue:
93cc12bc720ae5a1d83495b5b320e2bc2ae7531a

Now waiting for an exception to commit "Power Management" instead of "PowerDevil"
Comment 11 Jonathan Riddell 2015-03-11 19:18:49 UTC
This bug is reported on libsolid which is the kdelibs4 version of the solid library.  It is now in maintenance mode.  If you think it should still be fixed in the KDE Frameworks 5 version of solid please move it to or report a bug on frameworks-solid or Powerdevil.
Comment 12 Martin Flöser 2015-03-13 07:25:10 UTC
still visible in Plasma 5.
Comment 13 Lukáš Tinkl 2015-03-13 10:16:28 UTC
Git commit 32a6a3a8d4bc80f62e62549877efe34fa3b34366 by Lukáš Tinkl.
Committed on 13/03/2015 at 10:15.
Pushed by lukas into branch 'master'.

rename the visible name to Power

fixes 309816 - Searching for sleep/hibernate shows title "PowerDevil"

M  +1    -73   runners/powerdevil/plasma-runner-powerdevil.desktop

http://commits.kde.org/plasma-workspace/32a6a3a8d4bc80f62e62549877efe34fa3b34366