Bug 309787 - Krunner does not execute program when press ENTER
Summary: Krunner does not execute program when press ENTER
Status: RESOLVED FIXED
Alias: None
Product: krunner
Classification: Plasma
Component: general (show other bugs)
Version: 4.9.97 RC2
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: regression
: 310259 312698 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-11-09 01:30 UTC by Kevin Miller
Modified: 2013-02-02 14:58 UTC (History)
16 users (show)

See Also:
Latest Commit: http://commits.kde.org/kde-workspace/110504efad0116480df8ab17ab4d66a8fee1f905
Version Fixed In: 4.10
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Miller 2012-11-09 01:30:47 UTC 
After I type in an application and it is selected in krunner, usually pressing enter will launch the application. Since I upgraded to KDE 4.9.3 this function has stopped working. I have to manually click the program for the application to be launched.

Reproducible: Always

Steps to Reproduce:
1. ALT-F2 to start Krunner
2. Type any application.
3. When the application is selected, press ENTER
Actual Results:  
Nothing happens when I perform the steps above. 

Expected Results:  
When I press ENTER after typing the application name in krunner. The application should be launched.
Comment 1 Phil Woodland 2012-11-09 03:00:22 UTC 
Using Krunner (Alt+F2)

Expected:
Type partial name of application (ex: 'konso', 'system sett', etc.), have desired application show up as first in krunner list (ex: 'konsole' when typing partial 'konso'), hit return/enter, should launch Konsole (first in suggested list).
Actual: 
No reaction.

Expected:
Type entire name of application (ex: 'konsole'), shows 'konsole' it suggested list, enter/return should launch 'konsole'.
Actual:
No reaction.

After running Krunner (alt-F2), and typing: "konso".. if you press the up arrow (which goes through command history), then press down arrow, focus returns as was expected initially 


Running Kubuntu 12.10.
Comment 2 Christoph Feck 2012-11-09 10:30:39 UTC 
Regression caused by 1b878ffb

Aaron, is this intended?
Comment 3 Joachim Breitsprecher 2012-11-14 20:03:04 UTC 
*** This bug has been confirmed by popular vote. ***
Comment 4 Joachim Breitsprecher 2012-11-14 20:08:45 UTC 
I can confirm this bug on Gentoo Linux (x64).

Phil's workaround works for me too, but I would rather have Krunner accept the first suggestion right away when I press Enter.
Comment 5 Aaron J. Seigo 2012-11-15 13:21:51 UTC 
Git commit 110504efad0116480df8ab17ab4d66a8fee1f905 by Aaron Seigo.
Committed on 15/11/2012 at 14:20.
Pushed by aseigo into branch 'KDE/4.9'.

Revert "dont accidentally trigger the last match"

This reverts commit 1b878ffb55e6e1b7d51559ab8170c219768fa58b.

works as expected in master (nee 4.10); not sure why it does not in 4.9
and i don't have the time to suss it out. it can remain broken the way it
was prior to this commit in 4.9.

M  +2    -5    krunner/interfaces/default/interface.cpp

http://commits.kde.org/kde-workspace/110504efad0116480df8ab17ab4d66a8fee1f905
Comment 6 Jekyll Wu 2012-11-18 03:42:06 UTC 
*** Bug 310259 has been marked as a duplicate of this bug. ***
Comment 7 VaryHeavy 2012-11-18 13:50:11 UTC 
*** This bug has been confirmed by popular vote. ***
Comment 8 Diego Viola 2012-12-03 02:59:34 UTC 
I have this issue with KDE 4.9.3 (archlinux x86_64). Great to know it has been fixed. Thanks.
Comment 9 Rex Dieter 2012-12-07 14:38:04 UTC 
I'm seeing similar symptoms as this bug (return) after upgrading to kde-4.9.90 (4.10 beta2) :(
Comment 10 Diego Viola 2012-12-07 14:52:41 UTC 
I can confirm that I don't have this issue in KDE 4.9.4 anymore.
Comment 11 Diego Viola 2012-12-07 15:26:07 UTC 
So this issue is back with KDE 4.10?
Comment 12 Jekyll Wu 2012-12-07 15:55:22 UTC 
Not really back. 

The suspected problematic commit was *only* reverted for KDE/4.9 branch. It is still contained in KDE 4.10 betas.
Comment 13 Kevin Kofler 2012-12-07 22:46:10 UTC 
So this needs to be reopened.
Comment 14 Diego Viola 2012-12-07 23:38:27 UTC 
Why was the patch/fix merged only in the 4.9 branch? Why not merge it to master/HEAD or whatever the development branch is, so that the patch/fix gets merged in future releases as well?
Comment 15 Kevin Kofler 2012-12-08 00:14:24 UTC 
Because the developer who fixed it thought 4.10 was not affected, see comment #5.
Comment 16 Diego Viola 2012-12-08 01:03:06 UTC 
Please merge it into the latest 4.10 and further development branches. So that this issue never comes back again.

Thanks.
Comment 17 Diego Viola 2012-12-08 01:08:41 UTC 
(In reply to comment #16)
> Please merge it into the latest 4.10 and further development branches. So
> that this issue never comes back again.
> 
> Thanks.

*Please merge it into later branches as well.
Comment 18 Anne-Marie Mahfouf 2012-12-08 15:53:24 UTC 
Present in 4.10 beta2
Comment 19 Bernhard Friedreich 2012-12-27 10:30:17 UTC 
Still present in latest trunk.. please fix this as it makes krunner pretty much useless for fast program execution..
Comment 20 Sebastian Kuźlak 2013-01-05 10:54:57 UTC 
still present in 4.10 RC2......
Comment 21 Anne-Marie Mahfouf 2013-01-05 11:32:24 UTC 
Asking for he same patch that went to 4.9 branch to be included in 4.10 https://git.reviewboard.kde.org/r/108197/
Comment 22 Rex Dieter 2013-01-05 15:58:03 UTC 
Interestingly, the problem disappeared for me somewhere along the line, definitely working on now on 4.9.97.  One think I did was clear my plasma caches in /var/tmp/kdecache-<user>/*.kcache
Comment 23 Anne-Marie Mahfouf 2013-01-05 16:50:08 UTC 
Here the problem still exists even when clearing the cache. Rex it should have worked all along in the 4.10 series but I don't understand why it would work for you and not for others.

Anybody else willing to try clearing the cache and see if it fixes it for them?
Comment 24 Jekyll Wu 2013-01-05 17:09:50 UTC 
My experience implies this problem is mostly reproduciable under the following condition:

1. Create a brand new account and log in
2. in krunner, type "konqueror" exactly and slowly, wait for all matching to appear and stabilize, press "Enter"
Comment 25 Colin J Thomson 2013-01-05 17:44:51 UTC 
(In reply to comment #23)
> Here the problem still exists even when clearing the cache. Rex it should
> have worked all along in the 4.10 series but I don't understand why it would
> work for you and not for others.
> 
> Anybody else willing to try clearing the cache and see if it fixes it for
> them?

I just cleared my cache of all the *.kcache files and it fixed it for me temporarily. The problem returned after I logged out and logged back in again. Running Fedora 18, 4.9.97
Comment 26 Jekyll Wu 2013-01-05 18:15:04 UTC 
*** Bug 312698 has been marked as a duplicate of this bug. ***
Comment 27 Sebastian Kuźlak 2013-01-06 11:17:45 UTC 
(In reply to comment #25)
> (In reply to comment #23)
> > Here the problem still exists even when clearing the cache. Rex it should
> > have worked all along in the 4.10 series but I don't understand why it would
> > work for you and not for others.
> > 
> > Anybody else willing to try clearing the cache and see if it fixes it for
> > them?
> 
> I just cleared my cache of all the *.kcache files and it fixed it for me
> temporarily. The problem returned after I logged out and logged back in
> again. Running Fedora 18, 4.9.97

Same here. Removing .kcache fixes this for me temporarly.
Comment 28 Reza 2013-01-17 11:11:50 UTC 
Could any one try again with latest master?
Seem the problem related with this:
https://bugs.kde.org/show_bug.cgi?id=254365
which already fixed in commit 3894923 in KDE/4.10 and master branches of kde-workspace by aseigo.
Comment 29 dmatt 2013-01-20 21:48:58 UTC 
Tested in latest project Neon packages and the problem is fixed.