Bug 309152 - Text to speech plugin reads messages in history as "new message"
Summary: Text to speech plugin reads messages in history as "new message"
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Frameworks and Libraries
Component: text-ui-message-filters (show other bugs)
Version: git-latest
Platform: unspecified Linux
: NOR minor
Target Milestone: Future
Assignee: Daniele E. Domenichelli
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-28 15:49 UTC by Daniele E. Domenichelli
Modified: 2013-02-15 21:22 UTC (History)
2 users (show)

See Also:
Latest Commit: http://commits.kde.org/telepathy-text-ui/c77e98f5f8b2b2f8fc8fad1ca2c5dd5bd21dc53c
Version Fixed In: 0.6.0
ddomenichelli: ReviewRequest+

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Daniele E. Domenichelli 2012-10-28 15:49:04 UTC 
When the chat is opened text to speech plugin read all the incoming messages displayed in the log as "New nessage"
Comment 1 Daniele E. Domenichelli 2012-10-28 15:49:20 UTC 
*message
Comment 2 Daniele E. Domenichelli 2012-10-28 17:50:37 UTC 
Taking this since I almost have a patch ready
Comment 3 Martin Klapetek 2012-10-28 18:43:32 UTC 
Possibly related - bug 306650
Comment 4 Daniele E. Domenichelli 2012-10-28 19:07:40 UTC 
(In reply to comment #3)
> Possibly related - bug 306650

No, that's another problem, that's related to the backlog that is received when you connect to an xmpp chat and is at the moment handled as a new messages, while it should be handled as log.

This is the log that is filtered like the incoming messages
Comment 5 David Edmundson 2013-02-06 18:24:01 UTC 
Git commit c77e98f5f8b2b2f8fc8fad1ca2c5dd5bd21dc53c by David Edmundson.
Committed on 06/02/2013 at 17:05.
Pushed by davidedmundson into branch 'master'.

Compile against newer MessageProcessor
REVIEW: 108813

M  +3    -2    filters/emoticons/emoticon-filter.cpp
M  +2    -2    filters/emoticons/emoticon-filter.h
M  +2    -1    filters/formatting/format-filter.cpp
M  +1    -1    filters/formatting/format-filter.h
M  +2    -1    filters/images/images-filter.cpp
M  +1    -1    filters/images/images-filter.h
M  +10   -1    filters/texttospeech/tts-filter.cpp
M  +1    -1    filters/texttospeech/tts-filter.h
M  +2    -2    lib/chat-widget.cpp
M  +1    -2    lib/logmanager.cpp
M  +1    -1    logviewer/message-view.cpp

http://commits.kde.org/telepathy-text-ui/c77e98f5f8b2b2f8fc8fad1ca2c5dd5bd21dc53c